Bug 360232

Summary:	quicklaunch widget: no space between entries in popup, icons overlap
Product:	[Unmaintained] kdeplasma-addons	Reporter:	Janet <bugzilla>
Component:	Quicklaunch	Assignee:	David Rosca <nowrep>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, nowrep, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.5.4
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kdeplasma-addons/8ab5c13b5307baed76b0fb20aaba62f7ac539ac1	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	combined screenshot of quicklaunch popup with different dialog icon size works :)

Description Janet 2016-03-07 23:15:17 UTC

The popup of the quicklaunch widget uses the size of the dialog icons. Alas it does not adjust to the icon size so that the icons overlap when they are bigger than 32x32. I always use dialog icons of size 64x64 - and I cannot distinguish between the entries in the popup because the icons are just one overlapping bar. Even with 48x48 dialog icon size the icons overlap.

I could even live with a fixed icon size of 32 as kickoff menu has... That would be better than those jammend icons. Maybe you could use "small icons" or "toolbar icons" instead of "dialog icons", both would be more appropriate for a menu IMHO. But please adjust the space between the entries to the icons size.

Reproducible: Always

Steps to Reproduce:
1. Set the size for the dialog icons (systemsettings) to 48 or 64.
2. Place some icons in the drawer of the quicklaunch widget.
3. Open the popup drawer - the icons overlap. The more the bigger they are. 

Actual Results:  
The space between the entries is not adjusted to the icon size.

Expected Results:  
All icons in the popup should be clearly separated, the space must adjust to the size of the icons.

Comment 1 Janet 2016-03-07 23:29:53 UTC

Created attachment 97755 [details]
combined screenshot of quicklaunch popup with different dialog icon size

Comment 2 David Rosca 2016-03-08 14:32:35 UTC

Git commit 8ab5c13b5307baed76b0fb20aaba62f7ac539ac1 by David Rosca.
Committed on 08/03/2016 at 14:25.
Pushed by drosca into branch 'Plasma/5.6'.

Quicklaunch: Fix icon size in popup

Also add margins to text label.

M  +4    -1    applets/quicklaunch/package/contents/ui/IconItem.qml

http://commits.kde.org/kdeplasma-addons/8ab5c13b5307baed76b0fb20aaba62f7ac539ac1

Comment 3 Janet 2016-03-11 13:38:56 UTC

Created attachment 97842 [details]
works :)

Thanks, I applied the patch, it works :). The popup icons now are in size 32 while the dialog icons are still in desired bigger size. That's a much better default.

It is solved - but please allow some further question: If someone wants to have bigger icons than 32x32 in the popup (also with preserved space between the entries) one would have to change the "medium" in "width: units.iconSizes.medium" to something else. If I use "big" the icons are in 64x64. In that case there still/again is not enough spacing (same case as in the original). What would be needed to gain the desired space between the entries independent from the icon size? And what would be 48x48 - what lies between big and medium?

Comment 4 David Rosca 2016-03-11 15:28:30 UTC

units.iconSizes is defined here: https://quickgit.kde.org/?p=plasma-framework.git&a=blob&h=bb96e18ad9680cf1bd74cc9d9a4cf880316c02cb&hb=46a1181587c3d26c42caeec7281862753ec3f9b5&f=src%2Fdeclarativeimports%2Fcore%2Funits.cpp (in Units::iconLoaderSettingsChanged).

You will also need to change the value in quicklaunch/package/contents/code/layout.js in popupItemHeight function.

I may change it so the icon size is defined only in one place (and not in two as it is now), but this fixes the bug and is good enough.

Comment 5 Janet 2016-03-13 02:37:18 UTC

Thanks :)