| Summary: | Tag list is not filtered during face tag naming | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Kristian Karl <kristian.hermann.karl> |
| Component: | Faces-Engine | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin, mick, rs4000 |
| Priority: | NOR | ||
| Version: | 5.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/949e7bf27067af3ebb48685b31c7b58a3e57b736 | Version Fixed In: | 5.4.0 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot
Screenshot showing difference between left panel tags and righ panel |
||
|
Description
Kristian Karl
2016-03-06 10:16:42 UTC
Created attachment 97706 [details]
Screenshot
When I checked the same feature In the People view, it seems to work as expected there. Yes, we use inline completion in this overlay widget at moment. The popup from QCompleter would open in the upper left corner in the application. Move popup to the right coordinates must be implemented first. Maik This problem still valid using last digiKam 5.0.0 ? Gilles Caulier Yes, it's still a problem. I verified it in a build made from commit ac194b2c169d0d0fdedbe3048947c74cd242414e *** Bug 368125 has been marked as a duplicate of this bug. *** Git commit 949e7bf27067af3ebb48685b31c7b58a3e57b736 by Maik Qualmann. Committed on 29/12/2016 at 11:42. Pushed by mqualmann into branch 'master'. fix completion mode for manual face tagging Related: bug 374185, bug 372481, bug 284780, bug 368124 FIXED-IN: 5.4.0 M +6 -1 NEWS M +40 -2 libs/tags/addtagscombobox.cpp M +8 -0 libs/tags/addtagscombobox.h M +7 -3 libs/tags/tagscompleter.cpp M +10 -0 utilities/facemanagement/assignnamewidget.cpp M +2 -0 utilities/facemanagement/assignnamewidget.h M +9 -1 utilities/facemanagement/facegroup.cpp https://commits.kde.org/digikam/949e7bf27067af3ebb48685b31c7b58a3e57b736 Created attachment 103090 [details]
Screenshot showing difference between left panel tags and righ panel
Just tested in Build date: Dec 29 2016 (target: debug) Rev.: 949e7bf27067af3ebb48685b31c7b58a3e57b736 It still has non people tags in the suggestions list. Note - if I click on People in the left hand menu, under tags I see Events and 3 sub tag groups as well as People. Could this be the problem? I will attach a screenshot, you will see that some, but not all, Events are included. The left panel tags in your screenshots are only people tags, while the
right side displays all tags - so it is expected to be different.
I guess your problem is about what a people tag is. It is not a tag
below the parent People tag. Any tag can be a people tag. As soon as you
add a tag to a face area, this tag gets a flag applied that marks it as
a people tag. It seems you have such people tags also in your events
subtree, that's why it is displayed in the people sidebar.
> --- Comment #9 from Mick Sulley <mick@sulley.info> ---
> Just tested in Build date: Dec 29 2016 (target: debug)
> Rev.: 949e7bf27067af3ebb48685b31c7b58a3e57b736
> It still has non people tags in the suggestions list.
> Note - if I click on People in the left hand menu, under tags I see Events and
> 3 sub tag groups as well as People. Could this be the problem? I will attach
> a screenshot, you will see that some, but not all, Events are included.
>
I tested it (compiled sources) and I can confirm that the bug is fixed. I have just gone through all of the non-people tags on the left, none of them link to any pictures, so I guess it is a problem with the database. Do you know which table identifies a tag as a face tag? Here you have an OpenOffice document with Database table details : https://cgit.kde.org/digikam.git/tree/project/documents Gilles Caulier |