Bug 360149

Summary: Template titles no longer working in version 15.xx
Product: [Applications] kdenlive Reporter: Alan Hagge <nospam.ah>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal CC: nospam.ah, wegwerf-1-2-3
Priority: NOR Keywords: regression
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Example use of template title in 0.9.10
Screenshot showing centered "%s" on template title
Screenshot showing resulting text overlay (not centered)

Description Alan Hagge 2016-03-06 02:17:07 UTC
With kdenlive 0.9.10 and below, I found template titles to be extremely useful for inserting quick title information on a screen.  However, template titles do not seem to be functional in the 15.xx releases (I'm currently using 15.13.0+git20160305.84c724b3-0ubuntu0~sunab~wily1 from the sunab svn repository, but it has not functioned with any 15.xx release that I've tried).

The symptom is that if I open an existing template title, it shows up in the Project Bin area, but right-clicking and choosing "Clip Properties" to modify the text does not bring up any dialog at all.  It's basically treated as a standard clip, where double-clicking on it brings up the Title Clip editor.

I use the function so frequently that right now I'm forced to use the 0.9.10 release.  I'm hoping that this will be an easy bug to quash, but that it just hasn't been reported yet.

Reproducible: Always

Steps to Reproduce:
1. Open a new project
2. Use the title editor to create and save a template title
3. Load the template title via the Project Bin
4. Right click on the template title and select Clip Properties

Actual Results:  
Nothing.  No dialog box appears.

Expected Results:  
Dialog with Text box should appear to enter template text.

See https://userbase.kde.org/Kdenlive/Manual/Titles#Template_Titles_-_User-Defined

No workaround that I have found.  Only option is to create individual titles, which is a LOT more effort.
Comment 1 Jean-Baptiste Mardelle 2016-03-06 12:34:59 UTC
Correct, this was somehow lost in the KF5 port. I agree it's very useful, will try to bring it back for the 16.04 release
Comment 2 Jean-Baptiste Mardelle 2016-03-06 13:28:52 UTC
Git commit fa05879d02b693ecae888ba429b5b62767820dc4 by Jean-Baptiste Mardelle.
Committed on 06/03/2016 at 13:26.
Pushed by mardelle into branch 'master'.

Restore editable Title Template clips

M  +2    -3    src/bin/projectclip.cpp
M  +2    -2    src/dialogs/clipcreationdialog.cpp
M  +5    -1    src/mltcontroller/clipcontroller.cpp
M  +24   -6    src/mltcontroller/clippropertiescontroller.cpp
M  +3    -0    src/mltcontroller/clippropertiescontroller.h
M  +2    -2    src/mltcontroller/producerqueue.cpp
M  +1    -5    src/titler/titlewidget.cpp

http://commits.kde.org/kdenlive/fa05879d02b693ecae888ba429b5b62767820dc4
Comment 3 Alan Hagge 2016-03-08 02:30:19 UTC
Created attachment 97756 [details]
Example use of template title in 0.9.10

This image shows how I use a variable number of spaces in the Description field of template titles to be able to center the text (horizontally) on the screen.
Comment 4 Alan Hagge 2016-03-08 02:32:33 UTC
Wow - incredibly fast response - thanks!  I just updated to 15.13.0+git20160306 and I can see that I can now open properties to be able to enter title test.

But I have one issue (and two requests):

Issue:  Since there's currently no way to auto-center a template title, I used to put a "%s" on the left-hand side of the screen and then use spaces in front of my title text to center the title by hand, by trial-and-error (and a ruler).  It wan't quick or elegant, but it worked.  But now if I attempt to put spaces before the text in the dialog, they're removed from the dialog box as soon as I click "Apply".  But what's even stranger is that from the placement of the title text on the video, it appears that they ARE being used.  But it makes it virtually impossible to accurately center the text.

Request #1:  The 0.9.10 version used the "Description" field in the Project Tree as the title text.  Thus, I could see how a number of titles aligned and could more easily center them.  It is also faster to add/change the title text than having to right click on the clip and mouse down to select "Properties".  Would it be possible to restore that functionality?  See attach png image for an example of how I use the spaces in the Description field to horizontally center text.

Request #2:  Request #1 basically makes it easier to work around the lack of automatic centering of template titles.  If that functionality existed, it would eliminate the need for "fixing" the above issue and make the need for Request #1 significantly less.  Is it possible to implement auto-centering for template titles (perhaps by using a different "special character" (like %c) to indicate that the template text should be automatically centered?

I look forward to having an even easier and faster-to-use kdenlive - thanks for your help!
Comment 5 Jean-Baptiste Mardelle 2016-03-08 19:05:44 UTC
Git commit 167e9c08427f60d79683921c2c2a855d77f72d1b by Jean-Baptiste Mardelle.
Committed on 08/03/2016 at 19:05.
Pushed by mardelle into branch 'master'.

Fix whitespaces trimmed from display in template text edit

M  +3    -2    src/mltcontroller/clippropertiescontroller.cpp

http://commits.kde.org/kdenlive/167e9c08427f60d79683921c2c2a855d77f72d1b
Comment 6 Jean-Baptiste Mardelle 2016-03-12 08:17:40 UTC
Git commit 518d8747442e909af007704e46af20de5fb2d7f1 by Jean-Baptiste Mardelle.
Committed on 12/03/2016 at 08:17.
Pushed by mardelle into branch 'master'.

Template title text editable in Description column of Bin

M  +3    -0    src/bin/bin.h
M  +12   -2    src/bin/projectclip.cpp
M  +4    -0    src/mltcontroller/clipcontroller.cpp
M  +15   -7    src/mltcontroller/clippropertiescontroller.cpp

http://commits.kde.org/kdenlive/518d8747442e909af007704e46af20de5fb2d7f1
Comment 7 Jean-Baptiste Mardelle 2016-03-12 08:20:06 UTC
If you use latest versions of MLT and Kdenlive's git, template text should now align correctly, no more need to put whitespaces to center! Also text is now editable like previously from the "Description" column in Bin. feedback welcome.
Comment 8 Alan Hagge 2016-03-22 22:17:38 UTC
Created attachment 98029 [details]
Screenshot showing centered "%s" on template title
Comment 9 Alan Hagge 2016-03-22 22:18:35 UTC
Created attachment 98030 [details]
Screenshot showing resulting text overlay (not centered)
Comment 10 Alan Hagge 2016-03-22 22:25:27 UTC
Thanks for the prompt fix, but I'm not sure I understand how it's supposed to work.  I created a template title with a "%s" centered horizontally (and set toward the bottom of the screen vertically - see attachment).  But after I put text into the Description and inserted the Template title into the timeline, the text appears, but isn't centered (it's as though the text starts at the location of the "%s" in the template).

I guess I was expecting the text to be horizontally centered around where ever the "%s" is placed.

Can you describe how I should use it now, and what I might be doing wrong?

This is using kdenlive version 4:16.07.70+git20160321.1e66f4b5-0ubuntu0~sunab~wily1
Comment 11 Jean-Baptiste Mardelle 2016-03-22 22:30:14 UTC
Hmm, now that you say it I realize that the workflow is not really intuitive. In fact, you also need to set the text alignment ("Align" property in the text properties widget) to "centered". Please test and let me know if it works.
Comment 12 Alan Hagge 2016-03-22 22:37:11 UTC
Ahh, OK.  I just tried that and it seems to be working.  So it's a great addition, but the documentation definitely needs to be updated to reflect it, as I know that the forums had at least one other person mentioning the lack of ability to center text in a template title.

Thanks!  This will really help my transition to 16.xx!