| Summary: | Deleted uses the direct window type, but doesn't perform hack resolutions | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Max Schettler <max.schettler> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | max.schettler |
| Priority: | NOR | ||
| Version First Reported In: | 5.5.5 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Support information
kwinrc Support information (updated) Urxvt xprop |
||
|
Description
Max Schettler
2016-03-05 19:48:21 UTC
please attach the output of qdbus org.kde.KWin /KWin supportInformation Created attachment 97875 [details]
Support information
The effect isn't loaded - can you please attach ~/.config/kwinrc Created attachment 97876 [details]
kwinrc
The effect is not configured to be enabled ... What happens if you configure it by "kcmshell5 kwineffects" and does the checkbox reflect the assumed state? Created attachment 97877 [details]
Support information (updated)
I'm sorry, I forgot to reenable the effect. I updated the support information. Update: the effect is working on some windows, it works for example for firefox, the settings panel and d-feet. rxvt-unicode however does not use the effect. Also, it is triggered twice for the windows with which it works. can you please provide the xprop output of a window where it doesn't work? The bug goes a tiny little bit beyond the effect ;-) commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825 Author: Martin Gräßlin <mgraesslin@kde.org> Date: Wed Mar 4 08:26:57 2015 +0100 Copy NET::WindowType to Deleted This was suggested to be done in a comment. The existing code might have returned incorrect results for Client. So let's get the primary window type and use that one. I think the patch is wrong and terribly misgot the comment - the idea was likely to copy over the *indirect* type, ie. Normal if it's unknown and not a transient etc. (and urxvt doesn't seem to support NETWM) This fixes it: -------------------- diff --git a/deleted.cpp b/deleted.cpp index 5e0225f..e784bd1 100644 --- a/deleted.cpp +++ b/deleted.cpp @@ -84,7 +84,7 @@ void Deleted::copyToDeleted(Toplevel* c) m_layer = c->layer(); m_frame = c->frameId(); m_opacity = c->opacity(); - m_type = c->windowType(true); + m_type = c->windowType(); m_windowRole = c->windowRole(); if (WinInfo* cinfo = dynamic_cast< WinInfo* >(info)) cinfo->disable() Glad to see there is some issue resolved in the core code now, I just stumbled upon this issue while trying some settings. I don't think it's need anymore but I attached the xprop of a urxvt window anyway. Will the fix also resolve the effect being applied twice? Created attachment 97901 [details]
Urxvt xprop
I could not reproduce any double invocation. Does it remain if you disable: kwin4_effect_fade blur contrast Disabling those extensions (I just used fade from the kcmkwin assuming it is kwin4_effect_fade) makes the effect appear only once and in full length (which it didn't before, it was two times very quick and short). Deleted copies indirect window type.
> it is triggered twice for the windows with which it works.
To me, it looks like a conflict between several effects, which shouldn't be the case anymore.
|