Bug 360080

Summary: KRunner: Separator line below selection not ideal
Product: [Plasma] plasmashell Reporter: Francis Herne <mail>
Component: Theme - BreezeAssignee: visual-bugs-null
Status: RESOLVED FIXED    
Severity: wishlist CC: kde, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.5.95   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: http://commits.kde.org/milou/71facea055215013870557e6f1215ea1bd89a919 Version Fixed/Implemented In: 5.6.0
Sentry Crash Report:
Attachments: Selection of item above and below separator line

Description Francis Herne 2016-03-04 16:24:05 UTC 
Trivial, I know...

When the item immediately above a separator line in KRunner is selected, the grey separator line is directly adjacent to the lower border of the blue* selection rectangle. This makes the border look thick or shadowed, and leaves stray-looking pixels at each side because of the radiused corners of the selection.

In contrast, when the item _below_ the separator is selected, the separator is hidden. This looks nicer.

Comparative screenshot attached.

Reproducible: Always
Comment 1 Francis Herne 2016-03-04 16:24:35 UTC 
Created attachment 97681 [details]
Selection of item above and below separator line
Comment 2 Kai Uwe Broulik 2016-03-04 19:01:26 UTC 
The problem is that each item has a line at the top, so the hovered item would need to tell the *next* item to hide it's line. Should be fairly trivial to fix, though.
Comment 3 Kai Uwe Broulik 2016-03-04 20:14:01 UTC 
Git commit 71facea055215013870557e6f1215ea1bd89a919 by Kai Uwe Broulik.
Committed on 04/03/2016 at 20:13.
Pushed by broulik into branch 'Plasma/5.6'.

Hide separator if the previous one is highlighted

Avoids an ugly double line
FIXED-IN: 5.6.0

M  +1    -1    lib/qml/ResultDelegate.qml

http://commits.kde.org/milou/71facea055215013870557e6f1215ea1bd89a919
Comment 4 Kai Uwe Broulik 2016-03-04 20:31:52 UTC 
Git commit 044de4fd5dad7d1b284dcaeca3a660c9a9bcf80b by Kai Uwe Broulik.
Committed on 04/03/2016 at 20:30.
Pushed by broulik into branch 'Plasma/5.6'.

Improve section hiding logic

Make sure we don't break the first item if currentIndex is -1 (can sometimes
happen when you wiggle around the mouse too much) and also hide it for the
current item as well (it used to do that before we got rid of all the lines iirc)

M  +3    -1    lib/qml/ResultDelegate.qml

http://commits.kde.org/milou/044de4fd5dad7d1b284dcaeca3a660c9a9bcf80b