Bug 360061

Summary: Colour list squashed vertically.
Product: [Plasma] Breeze Reporter: Francis Herne <mail>
Component: QStyleAssignee: Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status: RESOLVED FIXED    
Severity: minor CC: hugo.pereira.da.costa, jpwhiting, kdelibs-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
URL: https://i.imgur.com/v5OkseD.png
Latest Commit: http://commits.kde.org/breeze/84d19e95e3e7b6df64ea4aa2f44a8a8f6a8c92ab Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Same screenshot, not on imgur

Description Francis Herne 2016-03-04 11:39:50 UTC 
In SystemSettings 5.5.95 (5.6 beta), using the kde-unstable packages from Arch:

The rows of the colour list are sized to the text. This makes the view/edit boxes on the right extremely thin, which is ugly and makes comparing /setting colours difficult.

See the linked screenshot.

Reproducible: Always

Steps to Reproduce:
1. Open the 'Application Colour Scheme' KCM
2. Go to the 'Colors' tab (localisation bug...)
3. Observe ugly list.

Actual Results:  
List rows are sized to text and almost unpadded. Colour view/edit boxes on the right are squashed.

Expected Results:  
Rows have some padding, boxes are a reasonable size.
Comment 1 Francis Herne 2016-03-04 11:40:39 UTC 
Created attachment 97672 [details]
Same screenshot, not on imgur
Comment 2 Christoph Feck 2016-03-11 01:33:25 UTC 
Is this issue also visible with other widget styles, such as Fusion or Oxygen?
Comment 3 Francis Herne 2016-03-11 09:41:28 UTC 
Ah, no it isn't. Just with Breeze.
Comment 4 Hugo Pereira Da Costa 2016-03-11 12:27:48 UTC 
... will investigate
Comment 5 Hugo Pereira Da Costa 2016-03-21 14:37:36 UTC 
Git commit 69fd1e6e519484254eebfcd776458ea49272e5e9 by Hugo Pereira Da Costa.
Committed on 21/03/2016 at 14:35.
Pushed by hpereiradacosta into branch 'master'.

For buttons that have neither icon nor text, assume custom button and use provided
contentsSize for sizeForContents calculation.

M  +36   -16   kstyle/breezestyle.cpp

http://commits.kde.org/breeze/69fd1e6e519484254eebfcd776458ea49272e5e9
Comment 6 Hugo Pereira Da Costa 2016-03-21 14:38:58 UTC 
Git commit 84d19e95e3e7b6df64ea4aa2f44a8a8f6a8c92ab by Hugo Pereira Da Costa.
Committed on 21/03/2016 at 14:36.
Pushed by hpereiradacosta into branch 'Plasma/5.6'.

For buttons that have neither icon nor text, assume custom button and use provided
contentsSize for sizeForContents calculation.

M  +36   -16   kstyle/breezestyle.cpp

http://commits.kde.org/breeze/84d19e95e3e7b6df64ea4aa2f44a8a8f6a8c92ab