Bug 359811

Summary: git master 2016-02-25 - Keyframe issues in saved effects applied to a group of clips.
Product: [Applications] kdenlive Reporter: Evert Vorster <evorster>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Evert Vorster 2016-02-26 06:28:33 UTC
Using my usual workflow, I tuned my stack of filters, then saved them to a temp file. 
The I selected a bunch of clips, and applied my saved stack to all of them. 

When looking at the clips in the timeline they all turned black, just like when we had issues with the keyframe in the saved effects. 
I can only assume that when the effect stack is applied to a clip the beginning keyframe is calculated for each of the effects in the stack. 
However, when applying to a group of clips, this calculation does not appear to be done for each clip, and so the keyframes for the effects appear to be off the clip, which in turn then makes the clips go black, as the sliders for the effects are set to 0

Reproducible: Always

Steps to Reproduce:
1. Save stack of filters
2. Select a group of clips on the timeline
3. Right-click and apply stack to all the clips at once. 

Actual Results:  
All the clips with the newly applied filter stack goes black, as all the sliders in all the effects are set to 0. 

Expected Results:  
My stack applied to each clip as if I had applied the stack to each individually.
Comment 1 Jean-Baptiste Mardelle 2016-02-29 19:47:41 UTC
Git commit 29dc6a20880539f218ad02ba5498a2193f6a47d4 by Jean-Baptiste Mardelle.
Committed on 29/02/2016 at 19:47.
Pushed by mardelle into branch 'master'.

Fix effect corruption when applying custom effect to a group

M  +2    -2    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/29dc6a20880539f218ad02ba5498a2193f6a47d4
Comment 2 Evert Vorster 2016-03-04 03:26:52 UTC
Fixed, works perfectly, thanks very much!