Bug 359764

David: this is perhaps fixed by the recent fix you did where the same view object was binded for all panels?

(In reply to Marco Martin from comment #1)
> David: this is perhaps fixed by the recent fix you did where the same view
> object was binded for all panels?

You mean d0440dd8203a7bcb52a8d4e2e16c53efa5fa60da in plasma-workspace? In that case it didn't fix my problem. Currently using 5.5.95 wich has that commit.

Turns out this is partly caused by using a tiling wm and not kwin. I realize this will likely lead to closing this bugs as RESOLVED WONTFIX. However, it did work with Plasma 5.5 and on master until some point mid January and thus might be considered as a regression.

Any pointers where to look and how to improve or fix this would be greatly appreciated.

Best would be if you could identify the commit that broke it for you,
then we'd know what exactly is broken and we can see if there's a way
to fix it.

I can confirm this too. I'm using bspwm as a window manager, and recent update to 5.6 causes me this exact same behaviour.

Can you show me the output of xprop (and clicking on the panel) after resizing.

If that shows we're resizing properly and the WM is ignoring us, it'll be wontfix. 
If it shows we're not setting somethign properly I'll fix it.

Working panel in wanted size, plasma 5.5.x
http://pastebin.com/fMzZ8asf

Not working panel in wanted size, plasma 5.6.x
http://pastebin.com/RCubxhwk

I hope I understood your request!

You probably noticed this already, but only meaningful difference what I find in those two xprops:

In 5.5
user specified location: 312, 0
user specified size: 1608 by 28

In 5.6
user specified location: 365, 0
user specified size: 1555 by 28

That +53 difference in location is subtracted from the specified size. The rest goes somewhere hidden over borders?

I have the same issue, my WM is XMonad.

http://pastebin.com/RMVMhtyp

*** Bug 361338 has been marked as a duplicate of this bug. ***

Not working in xmonad:

WM_NORMAL_HINTS(WM_SIZE_HINTS):
        user specified location: 365, 0
        user specified size: 1555 by 28
        program specified minimum size: 1607 by 28
        program specified maximum size: 1607 by 28
        window gravity: Static

Not working in xmonad:
WM_NORMAL_HINTS(WM_SIZE_HINTS):
        user specified location: 312, 0
        user specified size: 1608 by 28
        program specified minimum size: 1608 by 28
        program specified maximum size: 1608 by 28
        window gravity: Static


Looks like I skip a resize as I set the min/max and assume it will then resize implicitly. 
(which a working WM would do)

If someone wants to make a patch, you'll need to adjust PanelView::resizePanel
so that resize() keeps it *also* within minimumSize() and maximiumSize()

can someone replace their panelsize::resizePanel() method to this:

void PanelView::resizePanel()
{
    QSize userSize;
    if (formFactor() == Plasma::Types::Vertical) {
        const int minSize = qMax(MINSIZE, m_minLength);
        const int maxSize = qMin(m_maxLength, screen()->size().height() - m_offset);
        setMinimumSize(QSize(thickness(), minSize));
        setMaximumSize(QSize(thickness(), maxSize));
        userSize = QSize(thickness(), qBound(minSize, m_contentLength, maxSize));
    } else {
        const int minSize = qMax(MINSIZE, m_minLength);
        const int maxSize = qMin(m_maxLength, screen()->size().width() - m_offset);
        setMinimumSize(QSize(minSize, thickness()));
        setMaximumSize(QSize(maxSize, thickness()));
        userSize = QSize(qBound(minSize, m_contentLength, maxSize), thickness());
    }
    resize(userSize.expandedTo(minimumSize()).boundTo(maximiumSize()));
    //positionPanel will be called implicitly from resizeEvent
}

Edit, the last line should be:
    resize(userSize.expandedTo(minimumSize()).boundedTo(maximumSize()));

I tried  to follow your suggestions from comment #11 and noticed that there is no PanelView::resizePanel() on Plasma/5.6 (old master I reported the bug against has become Plasma/5.6 in the meantime).

After seeing that there 6 new commits compared to Plasma/5.6 touching that code, I just tested master and *tada*, resizing the panel does work again! Thanks for that.

So, I guess that poses the question if said commits can be safely backported. If you want I could check what commits are exactly necessary to fix the issue.

I'm a bit confused.

The commit that broke things is only in master.

When you say master works, do you mean with comment #11 or just master on it's own?

(In reply to David Edmundson from comment #14)
> The commit that broke things is only in master.

Only speaking for me, but it broke at some point between Plasma 5.5 and 5.6.

> When you say master works, do you mean with comment #11 or just master on
> it's own?

Just master on its own.

I failed to find the offending commit between 5.5.x and 5.6 when bisecting. (Maybe some other component influenced it.)
But I did the same reversely to see which commit fixed my issue on current master:

commit 6f70e9f2fcd3791c0a923302f51eb6742987e1bf
Author: David Edmundson <kde@davidedmundson.co.uk>
Date:   Thu Mar 17 16:31:54 2016 +0000
    Cleanup resize
    Always keep resize() call within bounds ourselve

Additionally I cherrry-picked the following commits on top of Plasma 5.6.1 as they seem to depend on another:
- 3dd1ec8 Remove invalid emit
- 12f7cbf Don't set min and max size of window twice

This fixes it for me with awesome as WM. I also did a quick check with kwin, which seems to work as well.

Oh, so I accidentally fixed things when I tidied them up \o/
That's good to know.

I'll backport those 3 into 5.6 then.

I'm having same problem both with 5.6.5 and current plasma-desktop master (825f59e3f46978e3d51b279fbe01b5707874c927).

As bisecting shows, the offending commit is a ba733d16fb2849b2b2cc390ed89b5200dffb5c3f. When I reverted it, the panel resizing start working as expected

Based on comments in #17, I'm closing this as fixed.

Please reopen if it's not.