Bug 359752

Summary: ffmpeg does not build with ffmpeg 3.0
Product: [Unmaintained] kdemultimedia Reporter: Nicolas Pavillon <nicos>
Component: ffmpegthumbsAssignee: Multimedia Bugs <multimedia-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: cfeck, heiko.becker, martin.sandsmark, mpyne, samrog131, sitter
Priority: NOR    
Version First Reported In: 4.13.1   
Target Milestone: ---   
Platform: MacPorts   
OS: macOS   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: fixed patch based on the RR

Description Nicolas Pavillon 2016-02-24 13:46:48 UTC 
FFmpegthumbs uses deprecated functions of ffmpeg, which have been removed in ffmpeg 3.0, so that the package cannot be built with the latest version.

For what I can see, most of what would be required for porting would just involve symbols replacement (I could provide a patch for that if required), but it would also require to reimplement the video deinterlacing code, which would be more complicated.

Reproducible: Always

Steps to Reproduce:
1. Install ffmpeg 3.0 on system
2. Try to build ffmpegthumbs

Actual Results:  
Builds fails.

Expected Results:  
Compilation ends without errors
Comment 1 Rog131 2016-02-24 15:53:34 UTC 
KDE Review Board - Support for ffmpeg 2.9 (and 3.0) : https://git.reviewboard.kde.org/r/126992/

Builds but .xsession-errors will have the 'kioslave: ####### CRASH ######' error messages and there won't be new thumbnails.
Comment 2 Martin Sandsmark 2016-05-27 20:30:46 UTC 
http://ix.io/LSR seems to work here.
Comment 3 Martin Sandsmark 2016-05-27 20:31:45 UTC 
Created attachment 99219 [details]
fixed patch based on the RR
Comment 4 Michael Pyne 2016-05-28 00:24:21 UTC 
The patch seems to work in testing here.
Comment 5 Harald Sitter 2016-05-28 09:19:44 UTC 
Works for me. Good to go! ;)
Comment 6 Martin Sandsmark 2016-05-29 00:27:16 UTC 
forgot the BUG tag, but here it is: https://quickgit.kde.org/?p=ffmpegthumbs.git&a=commit&h=3978c762072b7bc16b2096819b7cfa2052deaf5e