Bug 359708

Summary: Updated holiday file for Ukraine
Product: [Frameworks and Libraries] frameworks-kholidays Reporter: 38dosb+99yi2ktucsx2c
Component: generalAssignee: John Layt <jlayt>
Status: RESOLVED FIXED    
Severity: normal CC: kdepim-bugs, winter
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://commits.kde.org/kholidays/c88b89db49874407ba4b7cf0266208fb64cb6b33 Version Fixed In:
Sentry Crash Report:
Attachments: A patch fixing this issue
The same patch with corrected capitalization
A holiday file with conditional expressions

Comment 1 38dosb+99yi2ktucsx2c 2016-02-23 16:40:23 UTC 
Created attachment 97379 [details]
A patch fixing this issue

I've attached a patch against the current kholidays.git HEAD (not tested).
Comment 2 38dosb+99yi2ktucsx2c 2016-02-23 16:48:47 UTC 
Created attachment 97380 [details]
The same patch with corrected capitalization
Comment 3 38dosb+99yi2ktucsx2c 2016-02-23 17:16:28 UTC 
The links to president.gov.ua are dead (I admit that I copied them from Wikipedia articles). The updated URLs are http://www.president.gov.ua/documents/8722014-18001 and http://www.president.gov.ua/documents/692015-18468
Comment 4 Allen Winter 2016-02-24 17:44:39 UTC 
Git commit cb0585c117fa532eac78cad1f88ec6fd1e80a439 by Allen Winter.
Committed on 24/02/2016 at 17:43.
Pushed by winterz into branch 'KDE/4.14'.

holidays_ua_uk - updated Ukrainian holidays

CHERRY-PICK: everywhere

M  +18   -6    kholidays/holidays/plan2/holiday_ua_uk

http://commits.kde.org/kdepimlibs/cb0585c117fa532eac78cad1f88ec6fd1e80a439
Comment 5 Laurent Montel 2016-02-25 08:00:06 UTC 
Git commit 08cb6ac11ce246e22c0fc5da8e6ccba66dbd09be by Montel Laurent.
Committed on 25/02/2016 at 07:59.
Pushed by mlaurent into branch 'master'.

Backport: holidays_ua_uk - updated Ukrainian holidays

M  +18   -6    holidays/plan2/holiday_ua_uk

http://commits.kde.org/kholidays/08cb6ac11ce246e22c0fc5da8e6ccba66dbd09be
Comment 6 38dosb+99yi2ktucsx2c 2016-02-25 09:27:52 UTC 
Thanks for applying the patch! But, unfortunately, I forgot to update the line "Updated: 2010-06-06", and it is misleading now. Also, should the past changes in the list of official holidays be reflected in the holiday file by using conditionals like "public on ((year >= 2015 ) ? [october 14] : noop)"?
Comment 7 Allen Winter 2016-02-25 16:18:17 UTC 
good idea about the conditional.
please make a new patch, test it and attach here.
Comment 8 Allen Winter 2016-10-16 15:52:53 UTC 
re-opening because we never added the conditionals as discussed in Comment 6.
Comment 9 38dosb+99yi2ktucsx2c 2017-02-23 19:28:20 UTC 
Created attachment 104196 [details]
A holiday file with conditional expressions

Sorry for my prolonged absence. I've attached a holiday file with the conditionals. It has been tested against KDE 4 only.
Comment 10 Allen Winter 2017-02-26 18:53:06 UTC 
Git commit c88b89db49874407ba4b7cf0266208fb64cb6b33 by Allen Winter.
Committed on 26/02/2017 at 18:51.
Pushed by winterz into branch 'master'.

holiday_ua_uk - updated
patch from guerrillamailblock

M  +31   -20   holidays/plan2/holiday_ua_uk

https://commits.kde.org/kholidays/c88b89db49874407ba4b7cf0266208fb64cb6b33