Bug 359654

Summary:	Option to download all attachments at once
Product:	[Applications] trojita	Reporter:	msjasinski
Component:	Desktop GUI	Assignee:	Trojita default assignee <trojita-bugs>
Status:	RESOLVED UNMAINTAINED
Severity:	wishlist	CC:	arnaudv6, dieter.kde
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description msjasinski 2016-02-21 23:36:36 UTC

Feature request.
Useful e.g. when there are many photos attached to email. 
Other clients can do it (I think, Thunderbird, gmail, the Bat).

Reproducible: Always

Comment 1 Jan Kundrát 2016-02-22 12:59:56 UTC

Sounds liek a nice feature, patches are welcome.

An implementation of this feature should probably build upon the MIME part walking code (see src/UiUtils/PartWalker_impl.h), implementing a new visitor which only cares about the visitAttachmentPart() event. E-mail messages are not just "a text body" with "some attachments"; they are a recursively defined tree structure with arbitrary nesting and some parts which usually happen to be attachments.

Comment 2 msjasinski 2016-02-22 17:07:57 UTC

Thank you for endorsement.

Comment 3 Dieter Ehlers 2020-06-21 09:52:23 UTC

I did as you suggested, Jan, and implemented an AttachmentVisitor as a subclass of UiUtils::PartVisitor. Seems to work fine!
One minor question: Do we need to treat the case of a message/an attachment being larger than 2GB? I use a ProgressPopUp to indicate the download. In Gui/AttachmentView.cpp partIndex.data(Imap::Mailbox::RolePartOctets).toULongLong() is used, but ProgressPopUp/QProgressBar take int type.

Comment 4 Christoph Cullmann 2024-09-23 18:49:15 UTC

Trojitá is no longer maintained, please switch to a maintained alternative like https://apps.kde.org/kmail2/

Sorry for the inconveniences.