Bug 359583

Summary:	Contrast effect collides with inversion effect
Product:	[Plasma] kwin	Reporter:	Thomas Mitterfellner <thomas>
Component:	effects-various	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	thomas
Priority:	NOR
Version First Reported In:	5.5.4
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/kwin/9fae2f4905d5684f19d79bc2a5f839d9f07d7890	Version Fixed In:	5.14.3
Sentry Crash Report:
Attachments:	Picture demonstrating the problem

Description Thomas Mitterfellner 2016-02-19 19:01:21 UTC

When I invert screen colors, the start menu has too high a transparency making it hard to read if there's text behind it. Also, the entries on the panel including the systray are barely readable due to lacking contrast. I'try to attach a picture demonstrating that.

The interesting thing is: I *think* it wasn't like that from the start but I'm not 100% sure. I think it became like this at some point when I was using the Show Mouse effect. Unfortunately. I cannot confirm this as it seems to be persistent also after rebooting (which is why I'm unsure whether it hasn't been like that from the beginning).



Reproducible: Always




I added kwin support info here: https://paste.kde.org/pqim8h9pk

Comment 1 Thomas Mitterfellner 2016-02-19 19:03:39 UTC

Created attachment 97307 [details]
Picture demonstrating the problem

Comment 2 Thomas Lübking 2016-02-19 19:40:36 UTC

Can you please try to disable the contrast effect in "kcmshell5 kwineffects"

Also, the screenshot looks like this is a fullscreen inversion?
This should not run on the shaders at all (but on gamma ramps, which unlike the shaders is for free)

=> No xrandr or explicit invocation of the inversion effect?

Comment 3 Thomas Mitterfellner 2016-02-19 21:09:15 UTC

Indeed, disabling the contrast effect solves that problem. And yes, it's a full screen inversion. But I sometimes also use the window inversion.

Thanks for the quick response!

Comment 4 Thomas Lübking 2016-02-19 21:57:52 UTC

Can you try whether "xcalib -a -i" works for you (same command will invert the inversion ;-) - you may have to install xcalib.

@Martin
https://bugs.kde.org/show_bug.cgi?id=337355#c8

Shall I add a "remove contrast effect (seriously)" review request?
Afaics, it presently does nothing but waste resources and cause trouble. I'd frankly at least like to understand what it *wants* to do.

Comment 5 Vlad Zahorodnii 2018-10-23 13:53:15 UTC

Git commit 9fae2f4905d5684f19d79bc2a5f839d9f07d7890 by Vlad Zagorodniy.
Committed on 23/10/2018 at 10:57.
Pushed by vladz into branch 'Plasma/5.14'.

[effects/invert] Don't block blur and background contrast effect

Summary:
Background behind some windows is not blurred because the invert effect
sets PAINT_WINDOW_TRANSFORMED. This essentially "turns off" the blur and
the background contrast effect unless we set the force roles.

Because the invert effect is a "post-processing"(not really) effect we
don't have to set that flag.
Related: bug 279076
FIXED-IN: 5.14.3

Test Plan: {F6341916}

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16358

M  +0    -13   effects/invert/invert.cpp
M  +7    -2    effects/invert/invert.h

https://commits.kde.org/kwin/9fae2f4905d5684f19d79bc2a5f839d9f07d7890