Bug 359026

Summary:	ConfigViewPrivate::init() calls Corona::package() with this==NULL
Product:	[Frameworks and Libraries] libplasma	Reporter:	RJVB <rjvbertin>
Component:	libplasmaquick	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	crash
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-framework/1b2c1caf392dba833684f6156bbe0ad357e060e0	Version Fixed In:

Description RJVB 2016-02-05 14:26:45 UTC

I have built Qt 5.5.1 and KF5 Frameworks 5.17.0 for installation into /opt/local on a Kubuntu 14.04 host.

This crash occurs when I run plasma-windowed with the org.kde.plasma.digitalclock plasmoid, right-click the plasmoid window (which remains empty BTW) and request to change the clock settings.

The exact same crash occurs when I do this on OS X, using a build made with the same configure/packaging scripts (but evidently with additional patches).

Reproducible: Always

Steps to Reproduce:
1. opt/local/bin/plasmawindowed /opt/local/share/plasma/plasmoids/org.kde.plasma.digitalclock
2. right-click the window
3. select "digital clock settings" in the menu

Actual Results:  
crash

Expected Results:  
no crash, settings window opens or an appropriate error is presented.

Comment 1 RJVB 2016-02-05 14:32:19 UTC

It seems that PlasmaQuick::ConfigViewPrivate::init() is simply assuming that it always obtains a valid corona pointer, never corona == NULL which means that the test for corona->package().isValid() (line 119) can be devoid of meaning.

Comment 2 Marco Martin 2016-02-08 11:00:47 UTC

Git commit 1b2c1caf392dba833684f6156bbe0ad357e060e0 by Marco Martin.
Committed on 08/02/2016 at 10:59.
Pushed by mart into branch 'master'.

don't assume we find a corona
Change-Id: Idfb18a02f6e1ae35b0b1722c24a784345438003d

M  +4    -0    src/plasmaquick/configview.cpp

http://commits.kde.org/plasma-framework/1b2c1caf392dba833684f6156bbe0ad357e060e0