Bug 358958

Summary:	Missing Icons for virtual device in /dev
Product:	[Applications] dolphin	Reporter:	kailed <kailed>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	wbauer1
Priority:	NOR
Version:	15.12.1
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/dolphin/44d4d2ea715719a08c639541530a5b330647297d	Version Fixed In:	16.04.1
Attachments:	picture with missing icons

Description kailed 2016-02-03 17:11:54 UTC

There's no icons for device like sd* tty* in /dev. No matter which view or size.

Dolphin 15.12.1, QT 5.5.1 Kframework 5.18

Reproducible: Always

Steps to Reproduce:
1. point Dolphin to /dev
2.
3.

Actual Results:  
missing icons

Expected Results:  
icons like in kde-4

Comment 1 kailed 2016-02-03 17:12:46 UTC

Created attachment 96995 [details]
picture with missing icons

Comment 2 Wolfgang Bauer 2016-04-06 09:13:21 UTC

Probably related to Bug#361034...

Comment 3 Wolfgang Bauer 2016-04-22 19:40:10 UTC

(In reply to Wolfgang Bauer from comment #2)
> Probably related to Bug#361034...

I'm sure meanwhile that it is the same problem.
I created a patch to fix bug#361034, and it fixes the icons for /dev too...

*** This bug has been marked as a duplicate of bug 361034 ***

Comment 4 Wolfgang Bauer 2016-04-26 14:16:06 UTC

Git commit 44d4d2ea715719a08c639541530a5b330647297d by Wolfgang Bauer.
Committed on 26/04/2016 at 14:11.
Pushed by wbauer into branch 'Applications/16.04'.

Specify a fallback icon to QIcon::fromTheme()

The default fallback of QIcon::fromTheme() is QIcon(), i.e. a null icon.
Set the generic "unknown" icon as fallback to prevent missing icons for
filetypes that specify an icon name that doesn't exist.

This also gets rid of "QPixmap::scaled: Pixmap is a null pixmap"
warnings in that case.
Related: bug 361034
FIXED-IN: 16.04.1
REVIEW: 127713

M  +2    -1    src/kitemviews/kstandarditemlistwidget.cpp

http://commits.kde.org/dolphin/44d4d2ea715719a08c639541530a5b330647297d