Bug 358911

Summary:	MySQL database cannot be configured if INTERNAL_MYSQL=Off
Product:	[Applications] digikam	Reporter:	Weng Xuetian <wengxt>
Component:	Database-Mysql	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	5.0.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/d3c060d66b9e0a3746ef4e05aaadb456bbdf14c3	Version Fixed/Implemented In:	5.0.0
Sentry Crash Report:
Attachments:	patch

Description Weng Xuetian 2016-02-02 11:35:00 UTC

The database ui combo box index doesn't match the enum value if internal_mysql is off, thus it will always show the configuration for internal db, but no external mysql.

I made a patch for it at:
https://git.reviewboard.kde.org/r/126872/

Reproducible: Always

Steps to Reproduce:
1. build digikam with mysql=on and internalmysql=off
2. open database settings
3. select mysql

Actual Results:  
the db option still shows a db path instead of host name etc.

Expected Results:  
shows the correct ui with host, username etc,

Comment 1 caulier.gilles 2016-02-02 11:52:40 UTC

In your pathcn, please do not use std::array<int, 3> dbTypeMap; but a Qt map container instead.

Also do not use reviewboard, it's redondant with bugzilla. Post your updated patch to bugzilla as well..

Thanks in advance

Gilles Caulier

Comment 2 Weng Xuetian 2016-02-02 12:24:40 UTC

Created attachment 96977 [details]
patch

Comment 3 caulier.gilles 2016-02-02 14:07:10 UTC

Git commit d3c060d66b9e0a3746ef4e05aaadb456bbdf14c3 by Gilles Caulier.
Committed on 02/02/2016 at 13:51.
Pushed by cgilles into branch 'master'.

Apply patch #96977 to be able to configure Mysql DB if internal server is disabled
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +18   -12   libs/database/utils/dbsettingswidget.cpp

http://commits.kde.org/digikam/d3c060d66b9e0a3746ef4e05aaadb456bbdf14c3