Bug 358734

Summary:	Incorrect 2nd square HSV color picker (checked by HCG color model)
Product:	[Applications] krita	Reporter:	acterhd <acterhd>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	wishlist	CC:	griffinvalley, halla
Priority:	NOR
Version First Reported In:	3.0 Alpha
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	HCG screenshot Changed files Stable patch JavaScript original code HCG version 2 (color wheel added) HCG color selector version 2.1

Description acterhd 2016-01-29 13:05:55 UTC

Hello. I found bug with HSV2 square. Found by HCG color model patch for source code. 
I see that square is not right, slider moves to wrong directions. 

Reproducible: Always

Steps to Reproduce:
Very hard question. Need patch source code for support HCG (HST) color model. Need move sliders for check square. This patch are complex. 

Actual Results:  
Wrong color picker, from HCG view point.

Comment 1 acterhd 2016-01-29 13:07:35 UTC

Some info: 
https://github.com/acterhd/hcg-color
I wrote C++ version for QT.

Comment 2 acterhd 2016-01-29 13:59:41 UTC

Created attachment 96902 [details]
HCG screenshot

Bug fixed version (with HCG color model).

Comment 3 acterhd 2016-01-29 14:16:27 UTC

Created attachment 96903 [details]
Changed files

Most files was changed. Later I give real patch.

Comment 4 acterhd 2016-01-29 17:49:25 UTC

Here is topic about HCG color model. 
https://forum.kde.org/viewtopic.php?f=288&t=130828

Also, In my github you can found modded files of krita.

Comment 5 Halla Rempt 2016-01-30 10:37:49 UTC

I usually don't use github, but please add a link to the bug.

Comment 6 acterhd 2016-01-30 10:39:04 UTC

Created attachment 96915 [details]
Stable patch

Comment 7 acterhd 2016-01-30 10:47:31 UTC

Created attachment 96916 [details]
JavaScript original code

Comment 8 acterhd 2016-01-30 13:03:12 UTC

Created attachment 96920 [details]
HCG version 2 (color wheel added)

Comment 9 acterhd 2016-01-30 13:45:33 UTC

Created attachment 96921 [details]
HCG color selector version 2.1

Comment 10 acterhd 2016-01-30 15:51:40 UTC

Need add support before: 
https://bugs.kde.org/show_bug.cgi?id=358769

Comment 11 acterhd 2016-01-30 19:03:09 UTC

How bug is working? First, need implement HCG sliders to Krita.
After you can test HSV2. If moves in wrong direction - you found bug.

Comment 12 wolthera 2016-03-31 11:13:26 UTC

At this point I would rather you started to prepare it for building on Krita 3.0 as we're not supporting 2.9 anymore.

Comment 13 acterhd 2016-04-10 11:18:45 UTC

New patch. Not replaced HSV2, just added new color model HCG, with correct gradient. 
https://phabricator.kde.org/D1374

Comment 14 Halla Rempt 2017-11-27 09:31:37 UTC

The patch was abandoned, apparently, so closing the issue