Bug 358413

Summary:	Changes in query design not retained after changes in SQL view and switching to Data view
Product:	[Applications] KEXI	Reporter:	Jarosław Staniek <staniek>
Component:	Queries	Assignee:	Jarosław Staniek <staniek>
Status:	CLOSED FIXED
Severity:	normal	CC:	adam, dimitrios.tanis, inksi, staniek
Priority:	NOR
Version:	2.9.10
Target Milestone:	2.9.11
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kexi/bc54bad228e89548a929a30b5b1a54515e6a07d1	Version Fixed In:	2.9.11
Sentry Crash Report:

Description Jarosław Staniek 2016-01-23 10:27:16 UTC

1. Make any modification in SQL view, e.g. remove sorting
2. Change sorting in the Design view again
3. Switch to Data view and back to Design

Expected: sorting settings are kept

Observed: sorting settings are back to the state before point #2

Reproducible: Always, possible not just for sorting

Related to Bug #278379

Comment 1 Jarosław Staniek 2016-01-30 00:11:00 UTC

Git commit e8262276d8888e9058b19e16a9f6d495a15d600e by Jaroslaw Staniek.
Committed on 29/01/2016 at 22:08.
Pushed by staniek into branch 'calligra/2.9'.

Kexi: Fix state of 'modification' flag while switching from SQL view to Query Data view and back

Summary:
A general change in the logic of the Query Designer is that now we remember the view mode that was in use while the modification to design happened, not just the fact that the modification happened previously (since the last saving changes).
Related: bug 278379

Also fixes this:
Changes in query design not retained after changes in SQL view and switching to Data view

FIXED-IN:2.9.11

Test Plan: Follow the scenarios of the both bugs for any simple query such as "SELECT * FROM T ORDER BY F".

Reviewers: piggz, wicik

Projects: #kexi, #calligra:_3.0

Differential Revision: https://phabricator.kde.org/D856

M  +16   -16   kexi/plugins/queries/kexiquerydesignerguieditor.cpp
M  +1    -1    kexi/plugins/queries/kexiquerydesignerguieditor.h
M  +24   -17   kexi/plugins/queries/kexiquerydesignersql.cpp
M  +1    -1    kexi/plugins/queries/kexiquerydesignersql.h
M  +7    -6    kexi/plugins/queries/kexiquerypart.cpp
M  +10   -7    kexi/plugins/queries/kexiquerypart.h

http://commits.kde.org/calligra/e8262276d8888e9058b19e16a9f6d495a15d600e

Comment 2 Jarosław Staniek 2016-02-29 23:37:14 UTC

Git commit bc54bad228e89548a929a30b5b1a54515e6a07d1 by Jaroslaw Staniek.
Committed on 29/02/2016 at 23:07.
Pushed by staniek into branch 'master'.

Fix state of 'modification' flag while switching from SQL view to Query Data view and back

Summary:
A general change in the logic of the Query Designer is that now we remember the view mode that was in use while the modification to design happened, not just the fact that the modification happened previously (since the last saving changes).
Related: bug 278379

Also fixes this:
Changes in query design not retained after changes in SQL view and switching to Data view

FIXED-IN:2.9.11

Test Plan: Follow the scenarios of the both bugs for any simple query such as "SELECT * FROM T ORDER BY F".

Reviewers: piggz, wicik

Projects: #kexi, #calligra:_3.0

Differential Revision: https://phabricator.kde.org/D856

ported from calligra.git e8262276d8888e9

M  +16   -16   src/plugins/queries/kexiquerydesignerguieditor.cpp
M  +19   -10   src/plugins/queries/kexiquerydesignersql.cpp
M  +1    -1    src/plugins/queries/kexiquerydesignersql.h
M  +7    -6    src/plugins/queries/kexiquerypart.cpp
M  +10   -7    src/plugins/queries/kexiquerypart.h

http://commits.kde.org/kexi/bc54bad228e89548a929a30b5b1a54515e6a07d1