Bug 358384

Summary: Adding keyframe to Audio "Volume (keyframable)" effect doesn't put keyframe under position cursor in timeline (video example included)
Product: [Applications] kdenlive Reporter: Unknown <null>
Component: Video Effects & TransitionsAssignee: Vincent PINON <vpinon>
Status: RESOLVED FIXED    
Severity: normal CC: anton.gubarkov, jb, null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
URL: https://youtu.be/BnOJczdjgjI
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Unknown 2016-01-22 20:15:51 UTC
See video in URL field for example.

When you apply the Volume (keyframable) effect to an audio clip in the timeline, adding a keyframe doesn't put the keyframe right under the position cursor. It seems to put it in between the keyframe before and after it. This creates issues when trying to operate the keyframe function properly.

Reproducible: Always

Steps to Reproduce:
1. Add Volume (keyframable) effect to audio clip, or video clip with audio, in timeline.
2. Move position cursor in timeline to desired place for keyframe.
3. Go into properties widget.
4. Click on the Plus button to add keyframe.

Actual Results:  
Keyframe appears between the keyframes before and after it.

Expected Results:  
Keyframe to appear right under the position cursor in timeline.

Bug filed while testing Kdenlive-git 15.13.0.r6945.a1c63f9-1, running Antergos (Arch) Linux x64, GNOME 3.18.2.
Comment 1 Anton Gubarkov 2016-01-25 10:29:44 UTC
let me +1. It works this way for any effects I used: corners, white balance, pan&zoom.

The expected and intuitive behaviour is to create a new keyframe at the playhead position and put in the key-frameable attributes at their current calculated values (i.e. unless I manually tinker them, the new key frame has no effect).
Comment 2 Jean-Baptiste Mardelle 2016-02-04 10:21:52 UTC
We have almost finished a rewrite of the keyframe code, we just need to make sure older project files load correctly. I hope to enable the code in a few days, and it should hopefully fix this problem
Comment 3 Unknown 2016-02-08 22:23:56 UTC
Sweet JB. Looking forward to testing it out!
Comment 4 Unknown 2016-02-10 08:31:14 UTC
Just tested the latest git master build. It looks like this has been resolved, and the keyframe function is looking better and better. Thanks guys! Marking this bug as fixed.