Summary: | Tilde/variable expansion is treated differently than the equivalent path | ||
---|---|---|---|
Product: | [Plasma] krunner | Reporter: | Chris Spiegel <cspiegel> |
Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | alexander.lohnau, justin.zobel |
Priority: | NOR | ||
Version: | 5.5.3 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/736218793abd50d04bf140cc5cd2a8e9292c47f3 | Version Fixed In: | 5.21 |
Sentry Crash Report: | |||
Attachments: | Proof of concept patch to partially address the issue |
Description
Chris Spiegel
2016-01-19 18:34:36 UTC
Created attachment 96739 [details]
Proof of concept patch to partially address the issue
With this patch, search entries using a tilde which exist as local files are treated as such rather than as unknown URLs. It doesn't support variable expansion, so it's really just a proof of concept.
Confirmed here on openSUSE Tumbleweed. I agree, the path if it exists should be the first option. >With this patch, search entries using a tilde which exist as local files are treated as such rather than as unknown URLs.
This is fixed already. Variable expansion is more difficult, but I am on it :)
Git commit 736218793abd50d04bf140cc5cd2a8e9292c47f3 by Alexander Lohnau. Committed on 30/12/2020 at 10:43. Pushed by alex into branch 'master'. Expand ENV variables before displaying results Before the variables would get expanded later and consequently go through another code path than file locations. This leads to the text being differently displayed and users getting confused. Also this allows us to check if the file actually exists. FIXED-IN: 5.21 M +8 -14 runners/locations/locationrunner.cpp https://invent.kde.org/plasma/plasma-workspace/commit/736218793abd50d04bf140cc5cd2a8e9292c47f3 |