Bug 358101

Summary:	Keyboard layout button is too small to show the icons/text.
Product:	[Unmaintained] kscreenlocker	Reporter:	Christopher Welborn <cjwelborn>
Component:	breeze-theme	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, kde, kde, mgraesslin, mklapetek, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
URL:	http://i.imgur.com/NAnVlDW.jpg
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Christopher Welborn 2016-01-16 23:05:22 UTC

The keyboard layout button is not wide enough to show the icon/text inside of it. It ends up [looking like an empty button](http://i.imgur.com/NAnVlDW.jpg).

The setting `implicitWidth: minimumWidth` in `PlasmaComponents.Button` in the file `/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/KeyboardLayoutButton.qml` seems to cause this. Changing it to: `implicitWidth: 25` [fixes it](http://i.imgur.com/zwoLfBX.jpg).
 

Reproducible: Always

Steps to Reproduce:
1. Lock Screen
2. View the Keyboard Layout Button

Actual Results:  
The keyboard layout button looks empty. [Example here](http://i.imgur.com/NAnVlDW.jpg).

Expected Results:  
The keyboard layout buttons should be visible. [Example after fix is applied](http://i.imgur.com/zwoLfBX.jpg).

Comment 1 Christopher Welborn 2016-01-16 23:08:11 UTC

Sorry for the bad photo quality, PrintScreen wasn't working for me on the lock screen (probably a security thing?).

Comment 2 Kai Uwe Broulik 2016-01-17 00:05:41 UTC

Hi, thanks for your bug report and a suggestion to fix it.

However, hardcoded pixel sizes aren't particularly good, especially not in areas where text is displayed. Furthermore, I cannot reproduce this issue, the button looks fine on my machine, although I do get some layouting problems when switching layouts which might be related.

Print screen does not work on the lock screen because it grabs all keys, so you cannot interact with applications while the session is locked, only selected keys (such as volume controls) may be forwarded to a specific service explicitly by the lock screen.

Comment 3 Christopher Welborn 2016-01-17 01:28:31 UTC

Thanks for your reply. I understand about the hard coded pixels. It was just a workaround for my particular machine. I thought maybe someone more experienced in qml (than me anyway) might have an idea about what causes this. Screen size maybe? How could the button width be calculated without minimalWidth? Could it be based on the layout flag size? I'm gonna look into this some more.

Comment 4 Martin Klapetek 2016-01-17 02:02:45 UTC

I see the same issue.

Comment 5 sedrubal 2016-01-30 15:43:19 UTC

I see the same and sometimes the text is outside the button (when switching from "de(us)" to "de").

Comment 6 Nate Graham 2020-01-12 23:22:48 UTC

No longer an issue with the Plasma 5.9 and later lock screen design.