Bug 358061

Summary:	Improved/consistent mechanism to add/modify inline note
Product:	[Applications] okular	Reporter:	Simone Gaiarin <simgunz>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	REPORTED ---
Severity:	wishlist	CC:	haxtibal, simonandric5, visual-design
Priority:	NOR	Keywords:	usability
Version:	0.24.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Simone Gaiarin 2016-01-16 09:50:16 UTC

Currently the text of the inline note is not entered inline, but a qt message box to input the text appears. In this way we cannot have a live preview of how the note will look like.

Moreover when we edit the inline note and we double click onit, it's opened as a popup note for editing (but the first time we entered it we need to do it via a different popup dialog box). 

In my opinion the inline note should be both inserted and modified inline (if technically possible) or at least it should have a consistent way for inserting and modifying it in order to create less confusion to the user and have a better appearance.

Reproducible: Always

Comment 1 Simone Gaiarin 2017-05-03 07:09:05 UTC

Given that someone gave some love to the inline note I bump this bug which is related.

Comment 2 Tobias Deiminger 2018-01-22 20:58:58 UTC

+1 for inline editable (WYSIWYG) notes.

This would IMO require new API methods to render single annotations individually on poppler side.

Atm, poppler renders (slices of) pages. An inline editable note needed to trigger page rendering for each key stroke. This is a bit heavy considering processing time. Even if we only rendered the relevant page slice there'd still be overhead during rendering. Plus the corresponding Okular code would look ugly. There was a related bug for moving inline notes: https://bugs.kde.org/show_bug.cgi?id=333981. It's currently solved by only drawing an empty rectangle, which is obviously not an option during editing:) 

This is a matching wish on the poppler list: https://lists.freedesktop.org/archives/poppler/2017-April/012165.html. I guess it currently lacks interest and patches. Maybe we can bump and patch a bit?

As a bonus, https://bugs.kde.org/show_bug.cgi?id=325119 should get solved "for free".

Comment 3 Tobias Deiminger 2018-03-29 07:02:07 UTC

Just started a patch series on poppler that tries to provide a solution to the problem described in comment 2: https://bugs.freedesktop.org/show_bug.cgi?id=105796

Comment 4 Simone Gaiarin 2018-03-29 10:37:24 UTC

Cool. Thanks for the work!