Bug 358032

Summary:	Crash after closing KDESVN
Product:	[Applications] kdesvn	Reporter:	opensuse.lietuviu.kalba
Component:	General	Assignee:	KDESvn default assignee <kdesvn-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	Ch.Ehrlicher
Priority:	NOR	Keywords:	drkonqi
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/kdesvn/6a9795325296ca8cfc0f2e9b1fa96b6d9624d7ef	Version Fixed In:
Sentry Crash Report:

Description opensuse.lietuviu.kalba 2016-01-15 16:10:35 UTC

Application: kdesvn (1.7.0)
KDE Platform Version: 4.14.9
Qt Version: 4.8.6
Operating System: Linux 3.16.7-29-desktop x86_64
Distribution: "openSUSE 13.2 (Harlequin) (x86_64)"

-- Information about the crash:
- What I was doing when the application crashed:

I installed kdesvn 1.7.0 for testing from http://download.opensuse.org/repositories/home:/chehrlic/openSUSE_13.2/
I opened program, opened one bookmark, few second later opened another bookmark, few seconds later more – I closed application. Crash immediately.

-- Backtrace:
Application: kdesvn (kdesvn), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[KCrash Handler]
#6  0x00007f2c5bbca81a in QWidgetPrivate::deleteTLSysExtra() (this=this@entry=0x20e5020) at kernel/qwidget_x11.cpp:2885
#7  0x00007f2c5bb81895 in QWidgetPrivate::deleteExtra() (this=this@entry=0x20e5020) at kernel/qwidget.cpp:1832
#8  0x00007f2c5bb81abd in QWidgetPrivate::~QWidgetPrivate() (this=0x20e5020, __in_chrg=<optimized out>) at kernel/qwidget.cpp:365
#9  0x00007f2c5bf6b9af in QMenuPrivate::~QMenuPrivate() (this=0x20e5020, __in_chrg=<optimized out>) at widgets/qmenu_p.h:171
#10 0x00007f2c5bf6b9af in QMenuPrivate::~QMenuPrivate() (this=0x20e5020, __in_chrg=<optimized out>) at widgets/qmenu_p.h:183
#11 0x00007f2c5c7be0b5 in QObject::~QObject() (pointer=<optimized out>) at ../../src/corelib/tools/qscopedpointer.h:62
#12 0x00007f2c5c7be0b5 in QObject::~QObject() (this=0x20e3e48, __in_chrg=<optimized out>) at ../../src/corelib/tools/qscopedpointer.h:100
#13 0x00007f2c5c7be0b5 in QObject::~QObject() (this=0x20e3e40, __in_chrg=<optimized out>) at kernel/qobject.cpp:844
#14 0x00007f2c5bb8a4cc in QWidget::~QWidget() (this=0x20e3e40, __in_chrg=<optimized out>) at kernel/qwidget.cpp:1554
#15 0x00007f2c5b127949 in KMenu::~KMenu() (this=0x20e3e40, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kdeui/widgets/kmenu.cpp:168
#16 0x00007f2c5af9dfe6 in KActionMenu::~KActionMenu() (this=0x20e4450, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kdeui/actions/kactionmenu.cpp:77
#17 0x00007f2c5a8f55a9 in KBookmarkActionMenu::~KBookmarkActionMenu() (this=0x20e4450, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmenu.cc:765
#18 0x00007f2c5a8f792e in KBookmarkMenu::~KBookmarkMenu() (end=..., begin=...) at /usr/include/QtCore/qalgorithms.h:322
#19 0x00007f2c5a8f792e in KBookmarkMenu::~KBookmarkMenu() (c=...) at /usr/include/QtCore/qalgorithms.h:330
#20 0x00007f2c5a8f792e in KBookmarkMenu::~KBookmarkMenu() (this=0x1ecdac0, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmenu.cc:141
#21 0x00007f2c5a8f7989 in KBookmarkMenu::~KBookmarkMenu() (this=0x1ecdac0, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmenu.cc:143
#22 0x00007f2c5c7bbae8 in QObjectPrivate::deleteChildren() (this=this@entry=0x1e4abd0) at kernel/qobject.cpp:1944
#23 0x00007f2c5c7be07f in QObject::~QObject() (this=0x1eac500, __in_chrg=<optimized out>) at kernel/qobject.cpp:954
#24 0x00007f2c5a8f02ec in KBookmarkManager::~KBookmarkManager() (this=0x1eac500, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmanager.cc:308
#25 0x00007f2c5a8f0549 in KBookmarkManager::~KBookmarkManager() (this=0x1eac500, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmanager.cc:315
#26 0x00007f2c5a8ef46e in destroy() (end=..., begin=...) at /usr/include/QtCore/qalgorithms.h:322
#27 0x00007f2c5a8ef46e in destroy() (this=0x1e4b260, __in_chrg=<optimized out>) at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmanager.cc:53
#28 0x00007f2c5a8ef46e in destroy() () at /usr/src/debug/kdelibs-4.14.9/kio/bookmarks/kbookmarkmanager.cc:59
#29 0x00007f2c59c61bf9 in __run_exit_handlers (status=0, listp=0x7f2c59fcb5a8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true) at exit.c:82
#30 0x00007f2c59c61c45 in __GI_exit (status=<optimized out>) at exit.c:104
#31 0x00007f2c59c4bb0c in __libc_start_main (main=0x40a010 <main>, argc=3, argv=0x7ffd3da31a78, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd3da31a68) at libc-start.c:319
#32 0x000000000040ae82 in _start ()

Reported using DrKonqi

Comment 1 Christian Ehrlicher 2016-01-15 19:30:35 UTC

I can confirm this - you've a folder in your bookmarks, right?

Comment 2 opensuse.lietuviu.kalba 2016-01-15 19:31:46 UTC

Yes

Comment 3 Christian Ehrlicher 2016-01-15 19:53:33 UTC

I've created a patch, obs will soon provide a new package ( kdesvn-1.7.0-12.1.x86_64.rpm ). Please test

Comment 4 opensuse.lietuviu.kalba 2016-01-15 20:17:45 UTC

Thanks, patched kdesvn-1.7.0-12.1.x86_64.rpm no longer crash at exit

Comment 5 Christian Ehrlicher 2016-01-19 17:23:57 UTC

Git commit 6a9795325296ca8cfc0f2e9b1fa96b6d9624d7ef by Christian Ehrlicher.
Committed on 16/01/2016 at 16:43.
Pushed by chehrlic into branch 'master'.

Make kdesvn main window the parent of m_pBookmarkMenu so it gets deleted when the window gets destroyed. Otherwise it's deleted when KBookmarkmanager is destroyed (K_GLOBAL_STATIC) which is too late and may crash
REVIEW: 126762

M  +2    -2    src/kdesvn.cpp

http://commits.kde.org/kdesvn/6a9795325296ca8cfc0f2e9b1fa96b6d9624d7ef