Summary: | Viewport is selected inconsistently when navigating with left/right arrow keys | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Pastafarianist <dfasre> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bjohnson655, haxtibal, nate |
Priority: | NOR | Keywords: | triaged |
Version: | 0.20.3 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/okular/a29e4eaff5889eee632ce93c2e6a313cd9c011a1 | Version Fixed In: | 18.12.0 |
Attachments: | Example screenshot |
Description
Pastafarianist
2016-01-14 01:16:41 UTC
Created attachment 96634 [details]
Example screenshot
Here is what I am talking about. I was reading pages 7-8, then pressed right arrow and instead of showing only pages 9-10, Okular displayed this.
(Bugsquad) I tried scrolling large documents using the arrow keys, using facing pages view and various zoom settings, but in all cases scrolling using either the left or right arrow key causes the line break with the previous pages to align with the top of the view, and the position does not change with multiple scrolls. Application Version: 1.5.3 KDE Plasma Version: 5.14.3 KDE Frameworks Version: 5.52.0 Qt Version: 5.11.2 I could reproduce the described behavior while working on bug 400890. It has actually the same root cause, and should be fixed with https://phabricator.kde.org/D16941. Testing welcome. (shall we reopen for the meantime?) Git commit a29e4eaff5889eee632ce93c2e6a313cd9c011a1 by Tobias Deiminger. Committed on 29/11/2018 at 20:41. Pushed by tobiasdeiminger into branch 'Applications/18.12'. Fix inconsistent viewport positioning in PageView Summary: This diff unifies the calculation of the viewport position from a given DocumentViewport. PageView::notifyViewportChanged and PageView::slotRelayoutPages used to handle it differntly, which resulted in viewport jumps for no reason. It happened in various situations, e.g. when jumping to a page using the footer page navigation, or when reloading the document after presentation mode left, or when resizing the main window after presentation mode left. The diff selects the notifyViewportChanged way (align viewport top border with page top margin) as golden behavior in case of rePos.enabled == false. Related: bug 341939, bug 400890 341939 and 400890 are fixed partially. These two still suffer from a minor displacement that happens when finished signal arrives from pixmap generation thread. Test Plan: - When using the footer page navigation to jump to different pages, new page top is always algined with viewport top. - After changing page with footer page navigation, press F5 to reload. Page top stays aligned with viewport top. - When exiting presentation mode, and touching the file, page top stays aligned with viewport top. - When exiting presentation mode, and changing main window size, page top stays aligned with viewport top. Reviewers: #okular, sander Reviewed By: sander Subscribers: ngraham, sander, aacid, okular-devel Tags: #okular Differential Revision: https://phabricator.kde.org/D16941 A +- -- autotests/data/simple-multipage.pdf A +82 -0 autotests/data/simple-multipage.tex M +30 -0 autotests/parttest.cpp M +37 -30 ui/pageview.cpp M +1 -0 ui/pageview.h https://commits.kde.org/okular/a29e4eaff5889eee632ce93c2e6a313cd9c011a1 |