Bug 357887

Summary:	Calls to VG_(fclose) does not close the file descriptor
Product:	[Developer tools] valgrind	Reporter:	Nicolas Vienne <nicolas.vienne>
Component:	general	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	major	CC:	flo2030
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Nicolas Vienne 2016-01-12 13:48:38 UTC

I'm using Valgrind 3.11.0 built from sources on Ubuntu x86.
While redirecting lackey's logs to files, I noticed that file descriptors remained opened even after calling the method void VG_(fclose)( VgFile *fp ).
In that function, the "VG_(close)(fp->fd);" seems to be missing after flushing the buffer.

Comment 1 Florian Krohm 2016-01-12 14:32:57 UTC

(In reply to Nicolas Vienne from comment #0)
> I'm using Valgrind 3.11.0 built from sources on Ubuntu x86.
> While redirecting lackey's logs to files, I noticed that file descriptors
> remained opened even after calling the method void VG_(fclose)( VgFile *fp ).
> In that function, the "VG_(close)(fp->fd);" seems to be missing after
> flushing the buffer.

Oh yes, you're absolutely right. Thanks for reporting!
I've fixed this in r15755.