Bug 357856

Summary:	Can't disable track effects, deletion is not instantly shown
Product:	[Applications] kdenlive	Reporter:	qubodup
Component:	Video Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jb, wegwerf-1-2-3
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description qubodup 2016-01-11 17:42:12 UTC

I'm reporting these issues together because they seem to be closely related. They might be related to https://bugs.kde.org/show_bug.cgi?id=357053 as well.

kdenlive-git 15.13.0.r6895.171ad15-1
mlt-git r4157.v0.9.2.379.g676fcd8-1

Steps to reproduce:
1. Start Kdenlive
2. Add normalize effect to audio track 1
3. Press delete icon of the effect
4. Click on timeline, then on track header to empty the properties view.
5. Add normalize effect to audio track 2
6. Click disable icon of the effect
7. Click on timeline, then on track header to see the track effect properties again

Expected result:
3. -> effect gets deleted
7. -> effect is still disabled

Actual result:
3. -> effect stays in properties, disappears after deselecting and re-selecting the track header though.
7. -> effect is back to enabled mode

Videos:
Delete delay: https://youtu.be/cG_ciYaTwyw
Disable impossible: https://youtu.be/K9rlSQs6Szs

Comment 1 qubodup 2016-01-12 06:32:46 UTC

I just realized that the "Kdenlive doesn't remember (being-disabled) properties" also affects the composite transition's opacity setting.

Steps:
1. Create composite transition
2. Change opacity
3. Click away in timeline
4. Click on transtion

Expected:
1. Opacity is still changed

Actual:
1. Opacity is back to 100%

kdenlive-git 15.13.0.r6895.171ad15-1
mlt-git r4157.v0.9.2.379.g676fcd8-1

Video:
https://youtu.be/iyBTCfLIIN8

Comment 2 Wegwerf 2016-01-12 19:01:37 UTC

Hmm, could https://bugs.kde.org/show_bug.cgi?id=357756 be related too? Crop, Pan & Zoom looses at least some of its settings, already when leaving and returning to its properties window or even when just minimizing and then opening it again in the effects stack.

Comment 3 Jean-Baptiste Mardelle 2016-01-13 19:08:12 UTC

Seems to be a side effect of a change I made recently. Previously, composite transition (and Pan/Zoom) could only be edited if timeline cursor was on a keyframe. However I found it annoying when there is only one keyframe to always have to seek to the keyframe to edit the effect.

So I changed the behavior to allow editing whatever the timeline position is if there is only one keyframe. But I now realize that the settings are effectively lost if you were not on the keyframe when editing. Shouldn't be too hard to fix, will look at it.

Comment 4 Jean-Baptiste Mardelle 2016-01-13 20:03:45 UTC

Git commit efede114b6823bdf1603522cd52fd1d26906a4f2 by Jean-Baptiste Mardelle.
Committed on 13/01/2016 at 19:32.
Pushed by mardelle into branch 'Applications/15.12'.

Fix opacity parameter broken in composite transition/pan+zoom

M  +12   -4    src/effectstack/widgets/geometrywidget.cpp

http://commits.kde.org/kdenlive/efede114b6823bdf1603522cd52fd1d26906a4f2

Comment 5 Jean-Baptiste Mardelle 2016-01-13 20:03:58 UTC

Git commit 8a5e4c3c7bda32a6d8dbfa074e5d39cfc3a0f0b5 by Jean-Baptiste Mardelle.
Committed on 13/01/2016 at 20:03.
Pushed by mardelle into branch 'Applications/15.12'.

Fix track effects cannot be disabled / deleted
Fix effects staying in track effectstack after redoing deletion

M  +3    -1    src/effectstack/collapsibleeffect.cpp
M  +10   -12   src/effectstack/effectstackview2.cpp
M  +3    -2    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/8a5e4c3c7bda32a6d8dbfa074e5d39cfc3a0f0b5

Comment 6 qubodup 2016-01-16 01:11:24 UTC

Thanks, the issues described in this ticket are solved!