Bug 357804

Summary:	15.13.0: git master a5cd3e6: crashes when trying to add library item to project (w/ example)
Product:	[Applications] kdenlive	Reporter:	Wegwerf <wegwerf-1-2-3>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	example MLT playlist causing Kdenlive crash

Description Wegwerf 2016-01-10 17:18:57 UTC

The following attached MLT playlist library clip crashes the recent git master when trying to add it to any Kdenlive project.

#0  producer_get_frame (parent=0x7fff900c8470, frame=0x7fff900d1188, index=-1) at mlt_multitrack.c:554
#1  0x00007ffff6de536e in producer_get_frame (service=0x7fff900c8470, frame=0x7fff900d1188, index=-1) at mlt_producer.c:643
#2  0x00007ffff6de355c in mlt_service_get_frame (self=0x7fff900c8470, frame=0x7fff900d1188, index=index@entry=-1) at mlt_service.c:563
#3  0x00007ffff6decfd3 in transition_get_frame (service=0x7fff900cf0b0, frame=0x7fff9bffe688, index=0) at mlt_transition.c:447
#4  0x00007ffff6de355c in mlt_service_get_frame (self=0x7fff900cf0b0, frame=frame@entry=0x7fff9bffe688, index=index@entry=0) at mlt_service.c:563
#5  0x00007ffff6dedaff in producer_get_frame (parent=0x7fff900c2980, frame=0x7fff9bffe818, track=<optimized out>) at mlt_tractor.c:501
#6  0x00007ffff6de536e in producer_get_frame (service=0x7fff900c2980, frame=0x7fff9bffe818, index=0) at mlt_producer.c:643
#7  0x00007ffff6de355c in mlt_service_get_frame (self=self@entry=0x7fff900c2980, frame=frame@entry=0x7fff9bffe818, index=index@entry=0) at mlt_service.c:563
#8  0x00007ffff6df0bc8 in mlt_profile_from_producer (profile=0x7fff90003fa0, producer=0x7fff900c2980) at mlt_profile.c:414
#9  0x00007ffff6bc0bca in Mlt::Profile::from_producer(Mlt::Producer&) () from /home/harald/kdenlive-local/local/lib/libmlt++.so.3
#10 0x00000000009c5a19 in ProducerQueue::processFileProperties() ()
#11 0x00000000009ce3ce in QtConcurrent::VoidStoredMemberFunctionPointerCall0<void, ProducerQueue>::runFunctor() ()
#12 0x0000000000668db8 in QtConcurrent::RunFunctionTask<void>::run() ()
#13 0x00007ffff1ceee73 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff1cf22be in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x00007fffefee16aa in start_thread (arg=0x7fff9bfff700) at pthread_create.c:333
#16 0x00007ffff1302eed in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Reproducible: Always

Steps to Reproduce:
1. Start Kdenlive with empty project.
2. Add attached MLT playlist clip to project. The MLT playlist comes from Kdenlive's library.

Actual Results:  
Kdenlive crashes; in mlt_service_get_frame with an index of -1 :(

Expected Results:  
Kdenlive must not crash. :)

Please see attached MLT playlist clip that triggers the crash.

Comment 1 Wegwerf 2016-01-10 17:19:41 UTC

Created attachment 96567 [details]
example MLT playlist causing Kdenlive crash

Comment 2 Jean-Baptiste Mardelle 2016-01-10 18:53:42 UTC

Ok, found the problem, this is a 2 parts bug.
1 - there must be a bug in Kdenlive's save zone because somehow the transition has a_track=-1, so it is trying to apply the transition to a non existing track.
2 - This currently crashes MLT, which should also be fixed.

Working on it..

Comment 3 Jean-Baptiste Mardelle 2016-01-10 18:54:35 UTC

Git commit 56cb5c233b135a61d5064b065f5293499889b2e1 by Jean-Baptiste Mardelle.
Committed on 10/01/2016 at 18:53.
Pushed by mardelle into branch 'master'.

Fix playlist profile incorrectly detected,
Make sure saving timeline section does not produce invalid transitions

M  +7    -1    src/mltcontroller/producerqueue.cpp
M  +0    -1    src/monitor/glwidget.cpp
M  +4    -4    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/56cb5c233b135a61d5064b065f5293499889b2e1

Comment 4 Jean-Baptiste Mardelle 2016-01-13 21:36:42 UTC

Crash has now been fixed in MLT's git master:
https://github.com/mltframework/mlt/commit/dd12f73bde686efe87a9e5dff9e71fd59793ac5c