Bug 357756

Summary:	15.13.0: git master 0a36960: crop, scale & pos effect looses some of its settings
Product:	[Applications] kdenlive	Reporter:	Wegwerf <wegwerf-1-2-3>
Component:	Video Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED FIXED
Severity:	major	CC:	qubodup, wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	example project with color clip and CRP and Curves effects

Description Wegwerf 2016-01-09 18:29:51 UTC

Now this is a really crude bug, not easy to reproduce; I got bitten by it in a recent project I'm working on. When using the "Crop, Scale and Position" effect, the effect looses some of its parameters when the Curves effect is also present. This may happen also when other effects are used, by I did not dig into this direction. The parameters typically lost are "Clip top" and "Clip bottom". Sometimes, also "Clip right" gets lost. Your mileage may vary.

Reproducible: Always

Steps to Reproduce:
1. Create new project and add a color clip to it.
2. Place color clip on timeline.
3. Add "Crop, Scale and Position" effect to clip in timeline. Set its clip parameters, e.g. 12, 23, 34, 45.
4. Add a "Curves" effect too. Drag its curve points.
5. Save project.
6. New project (to get a clear situation).
7. Reload project.
8. Select color clip in timeline.
9. Check settings of the "Crop, Scale and Position" effect.

Actual Results:  
Often, effect settings have been changed. If not, try to change the Curves effect, save, new, reload again. Most of the time some of the Crop, Scale and Position effect's settings then will have been reset.

Expected Results:  
Effect parameter settings must not change, unless by user. Saving and reloading a project must not change effect settings.

Please see attached example project.

Comment 1 Wegwerf 2016-01-09 18:30:55 UTC

Created attachment 96545 [details]
example project with color clip and CRP and Curves effects

Comment 2 qubodup 2016-01-16 01:12:17 UTC

Now that https://bugs.kde.org/show_bug.cgi?id=357856 is fixed, would you mind trying to reproduce this issue again? I wasn't able to with your instructions. Hopefully this means this is fixed as well.

Comment 3 Wegwerf 2016-01-16 11:32:24 UTC

I've worked on a fifteen minute project yesterday with around a hundred cuts and 12 crop, scale, position effect using the recent fixes you mentioned. While the UI now behaves correctly,  there's still a part of this bug present: after loading, several instances of the effect showed correct settings, bit only some of it actually took effect. That is, left and right crop worked, but top and bottom wre shown correctly but not applies. Simply changing one of any effect parameters then causes correct synchronization between UI and applied effect.

Comment 4 Wegwerf 2016-01-18 20:27:03 UTC

Okay, more recent feedback: I've installed recent git Kdenlive and edited the aforementioned project. As soon as I collapse the crop, scale, and position effect in the effect stack, the project monitor updates and the complete clip content with the csp effect is gone. Unfolding the cap effect shows still correct parmeters, but the actual settings applied cause the clip to disappear from the rendered project frame. I need to touch one parameter (increaae or decrease it by 1) causes the current effect parmeters to be applied again correctly.

So, this bug is not fixed yet, unfortunately.

Comment 5 Wegwerf 2016-04-17 16:17:17 UTC

Seemed to be fixed now as part of another bug report on crop, scale, and position. I'm thus retiring this bug.