Bug 357658

Summary: Ark-15.12.0: default actions for clicking files: easy misconception of settings dialog
Product: [Applications] ark Reporter: Till Schäfer <till2.schaefer>
Component: generalAssignee: Elvis Angelaccio <elvis.angelaccio>
Status: RESOLVED FIXED    
Severity: minor CC: rakuco
Priority: NOR    
Version First Reported In: 15.12.0   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 16.12.0
Sentry Crash Report:

Description Till Schäfer 2016-01-07 15:54:02 UTC
When configuring ark to use an external preview application instead of the internal one, this works well while clicking the file. However, when using the preview action the internal preview is always used, regardless of the settings. 

Reproducible: Always
Comment 1 Elvis Angelaccio 2016-01-07 16:34:25 UTC
(In reply to Till Schäfer from comment #0)
> When configuring ark to use an external preview application instead of the
> internal one, this works well while clicking the file. However, when using
> the preview action the internal preview is always used, regardless of the
> settings. 

Hi Till, this is the expected behavior. The preview action and the open-file action are two different things.
The "Preview" button on the toolbar is always going to trigger the preview action. What you are looking for is the "Open File" action, which is currently not displayed by default on the toolbar (but it's available in the context menu when you right-click a file).

You can add this action also to the toolbar: go to the "Settings" menu, then click on "Configure Toolbars...". Now choose the <ark_part> toolbar from the drop-down menu. At this point you should see the "Open File" action from the available ones. You should be able to move it on the right, under the "Current actions" list.
(Note that the menu's names above may differ on your system, if you have Ark localized in your language).

Let me know you have problems doing so.
Comment 2 Till Schäfer 2016-01-07 17:15:53 UTC
Hi, 
I think the source of my misconception (from a user point of view) here is, that the category in the setting dialog is called "Preview". Therefore i expected the setting under this category to affect the preview and not the default double click behavior. 
After your answer i also read the text, which indeed gives the right explanation, but who reads all the dialog text (its maybe similar to AGBs :-) ) 

So maybe there is a way to present the setting more clearly, e.g. by just using a single checkbox: 
 [] use preview on clicking files or pressing the return key.

What do you think?
Comment 3 Till Schäfer 2016-01-07 17:19:49 UTC
The English translation for AGB (german) is  "general terms and conditions" ....
Comment 4 Elvis Angelaccio 2016-01-07 17:33:15 UTC
(In reply to Till Schäfer from comment #2)
> Hi, 
> I think the source of my misconception (from a user point of view) here is,
> that the category in the setting dialog is called "Preview". Therefore i
> expected the setting under this category to affect the preview and not the
> default double click behavior. 

I agree, this is confusing. This may be problably the right time to introduce a "General" category in the settings dialog.

> So maybe there is a way to present the setting more clearly, e.g. by just
> using a single checkbox: 
>  [] use preview on clicking files or pressing the return key.
> 
> What do you think?
This is basically what I initially proposed, but the KDE Visual Design guys argued that a single checkbox may be confusing, because you're not sure what the alternative is when you uncheck it.

I think that the best solution could be leaving the two radiobuttons, but moving them to a "General" settings category.
Comment 5 Till Schäfer 2016-01-07 17:46:40 UTC
(In reply to Elvis Angelaccio from comment #4)
> (In reply to Till Schäfer from comment #2)
> > Hi, 
> > I think the source of my misconception (from a user point of view) here is,
> > that the category in the setting dialog is called "Preview". Therefore i
> > expected the setting under this category to affect the preview and not the
> > default double click behavior. 
> 
> I agree, this is confusing. This may be problably the right time to
> introduce a "General" category in the settings dialog.
> 
> > So maybe there is a way to present the setting more clearly, e.g. by just
> > using a single checkbox: 
> >  [] use preview on clicking files or pressing the return key.
> > 
> > What do you think?
> This is basically what I initially proposed, but the KDE Visual Design guys
> argued that a single checkbox may be confusing, because you're not sure what
> the alternative is when you uncheck it.
good point.
> 
> I think that the best solution could be leaving the two radiobuttons, but
> moving them to a "General" settings category.
in this case i would read the text above the radio buttons, because the context is unclear.
Comment 6 Elvis Angelaccio 2016-01-08 23:19:48 UTC
All right, I'm confirming this report then.
Comment 7 Elvis Angelaccio 2016-11-17 15:18:08 UTC
Git commit 1caeff2b888dbff865bd8c879e21b10f10aec940 by Elvis Angelaccio.
Committed on 17/11/2016 at 15:08.
Pushed by elvisangelaccio into branch 'Applications/16.12'.

Add option to disable AES encryption warning

The new option is available in a new General Settings page in the settings dialog.
This paves the way for moving the radiobuttons currently in the Preview page.
Differential Revision: D3380

M  +2    -0    kerfuffle/CMakeLists.txt
M  +6    -0    kerfuffle/ark.kcfg
M  +2    -1    kerfuffle/compressionoptionswidget.cpp
A  +41   -0    kerfuffle/generalsettings.ui
A  +38   -0    kerfuffle/generalsettingspage.cpp     [License: BSD]
A  +45   -0    kerfuffle/generalsettingspage.h     [License: BSD]
M  +2    -0    part/part.cpp

http://commits.kde.org/ark/1caeff2b888dbff865bd8c879e21b10f10aec940
Comment 8 Elvis Angelaccio 2016-11-17 18:29:06 UTC
Git commit 5e3906ccf56dc54d373970fddae66fcdc35047b0 by Elvis Angelaccio.
Committed on 17/11/2016 at 18:26.
Pushed by elvisangelaccio into branch 'Applications/16.12'.

Move defaultOpenAction to General Settings page

This setting is about the default double-click behavior, so does not
really belong to the Preview page.
FIXED-IN: 16.12.0
Differential Revision: D3381

M  +8    -8    kerfuffle/ark.kcfg
M  +43   -0    kerfuffle/generalsettings.ui
M  +0    -58   kerfuffle/previewsettings.ui

http://commits.kde.org/ark/5e3906ccf56dc54d373970fddae66fcdc35047b0