| Summary: | No error message if file pasting failed | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Fabian Vogt <fabian> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | elvis.angelaccio, kde |
| Priority: | NOR | ||
| Version First Reported In: | 15.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/dolphin/0e5e43aa9d84b2a38db99c469de91e4de8017fc7 | Version Fixed/Implemented In: | 16.08.2 |
| Sentry Crash Report: | |||
I just encountered the same issue in Dolphin 16.08.0 (KDE Frameworks 5.26.0, openSUSE Leap 42.2 beta), when dragging files in splitview from the hard disk to a pen drive. I was puzzled because just the second before I moved a smaller file and it worked. If that were not the case, my work would be stalled. Would be cool if this is fixed for 5.8 LTS, because i really like the new version :D (coming from mint/kde 4.14) I can reproduce, marking as confirmed. Git commit 0e5e43aa9d84b2a38db99c469de91e4de8017fc7 by Elvis Angelaccio. Committed on 04/10/2016 at 15:30. Pushed by elvisangelaccio into branch 'Applications/16.08'. Hide message widgets only when reloading the view Otherwise an error message might be hidden before it's even shown. FIXED-IN: 16.08.2 REVIEW: 129061 M +1 -1 src/dolphinmainwindow.cpp M +6 -2 src/dolphinviewcontainer.cpp M +5 -0 src/dolphinviewcontainer.h http://commits.kde.org/dolphin/0e5e43aa9d84b2a38db99c469de91e4de8017fc7 |
Copying a file into clipboard and then pasting it into a directory with insufficient space does not work and no error message is shown. I tracked it down to connect(m_view, &DolphinView::directoryLoadingCompleted, m_messageWidget, &KMessageWidget::hide); in src/dolphinviewcontainer.cpp. The issue is that pasting a file causes an event to be triggered by KDirNotify, causing a refresh of the directory and in turn the signal directoryLoadingCompleted is emitted. This hides KMessageWidget again, so that it is never shown. Removing the connection isn't a proper solution and I don't know dolphin's code well enough to provide a proper fix. Reproducible: Always