Bug 357540

Summary:	ViewportParamsTest fails
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	marble-bugs
Status:	CONFIRMED ---
Severity:	normal	CC:	rahn
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Dennis Nienhüser 2016-01-04 19:28:50 UTC

Since this commit

commit 5b989a8
Author: Torsten Rahn <rahn@kde.org>
Date:   Mon Oct 19 00:41:43 2015 +0200

    Add automatically assigned detail levels to each node
    in a way that is remotely similar to Douglas-Peuckert.
    The detail level gets assigned via
    GeoDataLineStrings::optimized() which returns another
    lineString that holds detail level information.
    This call is currently made inside the PN2 and
    OSM file parser.
    The algorithm works best for long linestrings.
    Therefore the maximum benefit is made e.g. for
    the atlas map theme where performance increases
    by about 10-20%.


ViewportParamsTest fails like this:

PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString(Spherical Tesselate Diagonal IDL)
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString(Spherical Tesselate Latitude IDL)
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString(Spherical LatitudeCircle Longitude)
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString(Spherical LatitudeCircle Diagonal IDL)
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString(Spherical LatitudeCircle Latitude IDL)
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLineString2()
PASS   : Marble::ViewportParamsTest::screenCoordinates_GeoDataLinearRing()
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator NoTesselation normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator NoTesselation acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Mercator NoTesselation aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator Tesselate normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator Tesselate acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Mercator Tesselate aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator LatitudeCircle normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Mercator LatitudeCircle acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Mercator LatitudeCircle aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect NoTesselation normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect NoTesselation acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Equirect NoTesselation aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect Tesselate normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect Tesselate acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Equirect Tesselate aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect LatitudeCircle normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Equirect LatitudeCircle acrossIDLRing)
FAIL!  : Marble::ViewportParamsTest::geoDataLinearRing(Equirect LatitudeCircle aroundSPoleRing) 'poly->isClosed()' returned FALSE. ()
   Loc: [/home/dennis/marble/src/tests/ViewportParamsTest.cpp(484)]
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical NoTesselation normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical NoTesselation acrossIDLRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical NoTesselation aroundSPoleRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical Tesselate normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical Tesselate acrossIDLRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical LatitudeCircle normalRing)
PASS   : Marble::ViewportParamsTest::geoDataLinearRing(Spherical LatitudeCircle acrossIDLRing)
PASS   : Marble::ViewportParamsTest::setInvalidRadius()
PASS   : Marble::ViewportParamsTest::setFocusPoint()
PASS   : Marble::ViewportParamsTest::cleanupTestCase()
Totals: 59 passed, 6 failed, 0 skipped, 0 blacklisted
********* Finished testing of Marble::ViewportParamsTest *********

Comment 1 Dennis Nienhüser 2016-01-04 19:36:15 UTC

Git commit 486b1dcd75cf360c7002786d4ccb540db4260526 by Dennis Nienhüser.
Committed on 04/01/2016 at 19:36.
Pushed by nienhueser into branch 'master'.

Silence failing unit test for now.

Jenkins fails for two months in a row, rendering it useless.

M  +12   -0    tests/ViewportParamsTest.cpp

http://commits.kde.org/marble/486b1dcd75cf360c7002786d4ccb540db4260526

Comment 2 Dennis Nienhüser 2016-01-04 19:37:21 UTC

Git commit 2f2683a63200def9d6de328375733cde90249490 by Dennis Nienhüser.
Committed on 04/01/2016 at 19:37.
Pushed by nienhueser into branch 'Applications/15.12'.

Silence failing unit test for now.

Jenkins fails for two months in a row, rendering it useless.
(cherry picked from commit 486b1dcd75cf360c7002786d4ccb540db4260526)

M  +12   -0    tests/ViewportParamsTest.cpp

http://commits.kde.org/marble/2f2683a63200def9d6de328375733cde90249490

Comment 3 Justin Zobel 2021-03-09 22:51:27 UTC

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.