Bug 357411

Summary: Double arrows in applications list if legacy Plasma svgs are in theme
Product: [Plasma] plasmashell Reporter: obnosim
Component: Application Launcher (Kickoff) widgetAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.5.2   
Target Milestone: 1.0   
Platform: openSUSE   
OS: Linux   
URL: http://i.imgur.com/ZmFjY9p.png
Latest Commit: Version Fixed In: 5.6.0
Sentry Crash Report:
Attachments: Example toolbar-icons/go.svg file to trigger the bug

Description obnosim 2016-01-02 03:37:54 UTC
See URL for screenshot.

Since 5.5.0, Kickoff shows two kind of arrows on every listitem in its applications view. It shows left arrows from both widgets/arrows.svg and toolbar-icons/go.svg if it exists. The issue seems to stem from quickgit.kde.org/?p=plasma-desktop.git&a=blob&f=applets/kickoff/package/contents/ui/ApplicationsView.qml line 218. This was not the case in 5.4.3 and earlier versions.

The issue is not visible using Breeze because it does not provide the toolbar-icons folder.

Reproducible: Always

Steps to Reproduce:
1. Use a theme that provides toolbar-icons/go.svg [go-next]
2. Open Kickoff and switch to the Applications tab

Actual Results:  
Two kinds of arrows are used for every listitem

Expected Results:  
Only one arrow is used at most.
Comment 1 obnosim 2016-01-02 03:39:40 UTC
Created attachment 96402 [details]
Example toolbar-icons/go.svg file to trigger the bug

Save it as <theme>/toolbar-icons/go.svg to see the problem in Kickoff.
Comment 2 Kai Uwe Broulik 2016-03-07 17:07:49 UTC
Git commit 1018911cd77565b3950096abd6bdbb6374b705ff by Kai Uwe Broulik.
Committed on 07/03/2016 at 17:06.
Pushed by broulik into branch 'Plasma/5.6'.

[Kickoff] Remove old arrow icon code

This wasn't visible in Breeze but might break older themes that still ship with
this icon. The way it was implemented, just added ontop of the delegate, wasn't
particularly good anyway.
FIXED-IN: 5.6.0

M  +0    -20   applets/kickoff/package/contents/ui/ApplicationsView.qml

http://commits.kde.org/plasma-desktop/1018911cd77565b3950096abd6bdbb6374b705ff