Bug 357311

Summary:	plastik decorations: Color scheme changes are not applied immediately
Product:	[Plasma] kwin	Reporter:	Alex <allo>
Component:	aurorae	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	Flags:	mgraesslin: ReviewRequest+
Priority:	NOR
Version First Reported In:	5.4.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
URL:	https://git.reviewboard.kde.org/r/126891/
Latest Commit:	http://commits.kde.org/kwin/3434358acdd52ae1fbf21ce1f61bcfe56df26a1c	Version Fixed/Implemented In:	5.5.5
Sentry Crash Report:

Description Alex 2015-12-29 16:48:54 UTC

Color Changes are not applied for existing windows when using plastik decorations.

Reproducible: Always

Steps to Reproduce:
1. Go to systemsettings, color
2. Change the window decorations to Plastik
2. Change the colorscheme

Actual Results:  
The decorations do not change their color, new windows have the correct color. Changing it back and forth while opening new windows in between leads to having open windows with many different colored borders.

Expected Results:  
All decorations on all windows should instantly change their color.

Comment 1 Thomas Lübking 2015-12-29 17:19:19 UTC

!plastik == oxygen/breeze?

At least I don't think aurorae themes are colorable at all.

Comment 2 Alex 2015-12-29 18:49:03 UTC

nope, Plastik exists since 3.x times, its's that one:
https://czechia.kde.org/screenshots/images/3.2/snapshot07d.png

And it changes the color, it just does not instantly, but only for newly opened windows, while it works fine with the 4.x version.

Comment 3 Thomas Lübking 2015-12-29 18:54:44 UTC

dev / human - human / dev:
"!plastik" : "not plastik" ;-)
I wanted to know whether this is a problem in the breeze decoration, the oxygen deco or both.

However that was due to a misinterpretation of your subject, sorry.
The problem is /in/ plastik (and likely: "only"?)

Comment 4 Alex 2015-12-30 10:52:37 UTC

It is IN Plastik and not in the default decoration. I can try some other decorations later on the Fedora live cd i used, when it's needed.

Comment 5 Alex 2015-12-30 11:03:00 UTC

The Fedora 23 CD i am using has only breeze and Plastik.

Comment 6 Martin Flöser 2016-01-04 10:24:16 UTC

sounds like just a forced repaint is missing when switching the configuration. Should be easy to fix.

Comment 7 Martin Flöser 2016-02-25 07:04:48 UTC

Git commit 3434358acdd52ae1fbf21ce1f61bcfe56df26a1c by Martin Gräßlin.
Committed on 25/02/2016 at 07:04.
Pushed by graesslin into branch 'Plasma/5.5'.

[aurorae] Handle client palette changes

When the client's palette changes we need to update the internal colors
and emit a colorChanged, so that the decoration can repaint.
FIXED-IN: 5.5.5
REVIEW: 126891

M  +7    -0    clients/aurorae/src/decorationoptions.cpp
M  +1    -0    clients/aurorae/src/decorationoptions.h

http://commits.kde.org/kwin/3434358acdd52ae1fbf21ce1f61bcfe56df26a1c