Bug 357306

Summary: Build Broken on Windows
Product: [Frameworks and Libraries] frameworks-kcoreaddons Reporter: luca.beldi
Component: generalAssignee: Michael Pyne <mpyne>
Status: RESOLVED FIXED    
Severity: major CC: kdelibs-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Microsoft Windows   
Latest Commit: http://commits.kde.org/kcoreaddons/caf9e50da1d6ac94bfc844a4ba688a10aee851c0 Version Fixed/Implemented In: 5.18
Sentry Crash Report:

Description luca.beldi 2015-12-29 13:11:23 UTC 
Do not use QStringLiteral with multi-line string constants as it breaks the build on Windows.

see ktexttohtmltest.cpp row 151 and 196

This bug already affected KWidgetsAddon, see https://quickgit.kde.org/?p=kwidgetsaddons.git&a=commit&h=71dd42f902c8fa09f6eca5e762c2e46a45161767



Reproducible: Always

Steps to Reproduce:
Build KCoreAddons on MSVC

Actual Results:  
Build Fails
Comment 1 Michael Pyne 2015-12-31 02:12:09 UTC 
Git commit caf9e50da1d6ac94bfc844a4ba688a10aee851c0 by Michael Pyne.
Committed on 31/12/2015 at 02:07.
Pushed by mpyne into branch 'master'.

Fix multiline QStringLiteral usage to build on Windows.

Instead of using ::fromLatin1() I just used + to concatenate the string
literals. Both affected autotests still pass. Please reopen if build
still fails on Windows.
FIXED-IN:5.18

M  +4    -4    autotests/ktexttohtmltest.cpp

http://commits.kde.org/kcoreaddons/caf9e50da1d6ac94bfc844a4ba688a10aee851c0