| Summary: | KDESVN crash after entering password | ||
|---|---|---|---|
| Product: | [Applications] kdesvn | Reporter: | opensuse.lietuviu.kalba |
| Component: | General | Assignee: | Christian Ehrlicher <Ch.Ehrlicher> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | Ch.Ehrlicher |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 1.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdesvn/f7374b01f73eb4155516c355539028e65daf9160 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Possible fix
Simple patch against 1.6.0 |
||
|
Description
opensuse.lietuviu.kalba
2015-12-29 08:26:58 UTC
What password was it asking for? I think it was the password for your private ssh key for kde infrastructure, correct? At least that's the case here on my site. Yes, SSH password Ok, although I can't confirm the crash (after ~20 times asking for a password I gave up) with current git HEAD, I can confirm that the password is asked for an infinite time. I'll try to investigate what happens here. Maybe crash is related to fact, that at some time I opened another svn+ssh://svn@svn.kde.org/home/kde/ directory in same window Created attachment 96356 [details]
Possible fix
Proposed patch to fix this issue.
Is it possible for you to compile current kdesvn HEAD on your system to check if the attached patch will resolve the issue?
I prefer building RPM packages online by branhing existing packages, e.g. https://build.opensuse.org/package/show/KDE:Extra/kdesvn is for KDESVN. I tryed to add patch in https://build.opensuse.org/package/show/home:embar-:branches:KDE:Extra/kdesvn , but seems it requires same edit in patch for succesfull build... Created attachment 96357 [details]
Simple patch against 1.6.0
Here a simple patch against 1.6.0 :)
With patch for 1.6.0 build success. Thanks, now password requested only once ;) Git commit f7374b01f73eb4155516c355539028e65daf9160 by Christian Ehrlicher. Committed on 31/12/2015 at 08:47. Pushed by chehrlic into branch 'master'. Run ssh-add every time because we don't know if ssh-add was run before and all keys are added. Otherwise every svn action will result in a passphrase request REVIEW: 126572 M +5 -4 src/helpers/sshagent.cpp http://commits.kde.org/kdesvn/f7374b01f73eb4155516c355539028e65daf9160 After some updates (perhaps some SVN or SSH library update) via openSUSE security updates, KDESVN program again asks for password multiple times when connecting to svn+ssh://svn@svn.kde.org/home/kde/trunk/ ... Though they don't lead to crashing. Are you sure that you're using your own compiled kdesvn version? Sounds like it was overwritten with an old one. You can trigger the addition of your identity in kdesvn: - start kdesvn without url (from konsole to see possible error messages) - click subversion -> add ssh identities to ssh-agent - open your url btw: I've added an obs for kdesvn (currently only opensuse distributions) here: http://download.opensuse.org/repositories/home:/chehrlic/ kdesvn package didnot changed itseft: > LANG=C rpm -qi kdesvn Name : kdesvn Version : 1.6.0 Release : 23.1 Architecture: x86_64 Install Date: Tue Dec 29 15:23:06 2015 Group : Development/Tools/Version Control Size : 4372949 License : GPL-2.0+ Signature : RSA/SHA1, Tue Dec 29 15:02:23 2015, Key ID 1c1412b3f00e5642 Source RPM : kdesvn-1.6.0-23.1.src.rpm Build Date : Tue Dec 29 15:01:33 2015 Build Host : build12 Relocations : (not relocatable) Vendor : obs://build.opensuse.org/home:embar- URL : http://kdesvn.alwins-world.de/ Summary : KDE Subversion Client Description : kdesvn is a GUI client for subversion repositories. Distribution: home:embar-:branches:KDE:Extra / openSUSE_13.2 (In reply to Christian Ehrlicher from comment #11) > You can trigger the addition of your identity in kdesvn: > - start kdesvn without url (from konsole to see possible error messages) > - click subversion -> add ssh identities to ssh-agent > - open your url > Thanks, this helped! |