Bug 357242

Summary:	Use theme-defined color for task label shadow
Product:	[Plasma] plasmashell	Reporter:	obnosim
Component:	Task Manager and Icons-Only Task Manager	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	plasma-bugs, sabayon11
Priority:	NOR
Version:	5.5.0
Target Milestone:	1.0
Platform:	openSUSE
OS:	Linux
URL:	http://kde-look.org/content/show.php/Racy+For+Plasma+5?content=174633
Latest Commit:	http://commits.kde.org/plasma-desktop/6c3b01c52f4a7daac11a8f22cecc5e551d9bfcbb	Version Fixed In:
Sentry Crash Report:

Description obnosim 2015-12-28 04:27:59 UTC

quickgit.kde.org/?p=plasma-desktop.git&a=blob&f=applets/taskmanager/plugin/textlabel.cpp
line 233

Currently, the task manager arbitrarily chooses the color of the label shadow depending on the text color among two hard-coded options (black or white). It would be nice if it instead tried to use a color defined by the Plasma theme.
According to techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Colors, there is already an entry in the colors file that is supposed to be used for text decorations. It does not appear to be used anywhere in Plasma at the moment. I think that color (namely, [Colors:Window] DecorationHover) could be used for this purpose, or it could be any other currently unused color. Alternatively, it could be defined by adding a new element in widgets/tasks.svg. If that element isn't present in the file, the task manager could still choose the color itself. This would make sure old unmaintained themes stay unaffected.
This would give more leeway for customization (see URL) and could provide an easy way for users to correct problems like bug #313172.

Reproducible: Always

Comment 1 apache 2016-07-17 15:11:21 UTC

This is related issue:
https://bugs.kde.org/show_bug.cgi?id=365158#c10
https://forum.kde.org/viewtopic.php?f=17&t=133829

Both issues (color of text and color of shadow) are very old and sad story
Bug 183991 - remove plasma panel text shadow: 
https://bugs.kde.org/show_bug.cgi?id=183991

I know you have some priorities but please make it happen eventually. I will repeat myself: Breeze is not the only theme, certainly not the only way users want to customize their desktop.
https://forum.kde.org/viewtopic.php?f=285&t=133463
In my opinion such basic elements that affects the "look and feel" should be not hard coded but configurable in configuration files.

Comment 2 Eike Hein 2016-08-23 18:58:18 UTC

Git commit 6c3b01c52f4a7daac11a8f22cecc5e551d9bfcbb by Eike Hein.
Committed on 23/08/2016 at 18:57.
Pushed by hein into branch 'master'.

Drop the C++ text label implementation.

Summary:
After D2281 set the stage, this change drops the C++ label in favor
of the PlasmaComponents-based label added then. A consensus has
emerged that the things the C++ label did that the new label does
not do (fadeout gradients, shadowing) are not actually desirable.
Related: bug 346050, bug 360119

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2418

M  +0    -2    applets/taskmanager/CMakeLists.txt
M  +0    -3    applets/taskmanager/package/contents/config/main.xml
D  +0    -30   applets/taskmanager/package/contents/ui/CppTextLabel.qml
D  +0    -32   applets/taskmanager/package/contents/ui/QmlTextLabel.qml
M  +9    -10   applets/taskmanager/package/contents/ui/Task.qml
D  +0    -154  applets/taskmanager/plugin/blur.cpp
M  +0    -2    applets/taskmanager/plugin/taskmanagerplugin.cpp
D  +0    -278  applets/taskmanager/plugin/textlabel.cpp
D  +0    -80   applets/taskmanager/plugin/textlabel.h

http://commits.kde.org/plasma-desktop/6c3b01c52f4a7daac11a8f22cecc5e551d9bfcbb