Bug 357135

Summary: org.kde.breeze window specific overrides get lost everytime I click apply and ok
Product: [Plasma] Breeze Reporter: . <dev.rindeal+bugs.kde.org>
Component: window decorationAssignee: Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status: RESOLVED FIXED    
Severity: critical CC: hugo.pereira.da.costa
Priority: NOR    
Version: 5.5.1   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: http://commits.kde.org/oxygen/1dcaee368040692bf6de840465d40fe00a76f899 Version Fixed In:
Sentry Crash Report:

Description . 2015-12-24 23:26:07 UTC 
I've discovered a click-flow which causes all window-specific overrides to get lost.

Reproducible: Always

Steps to Reproduce:
1) run `kcmshell5 kwindecoration`
2) click on the menu icon of "org.kde.breeze" theme
3) select "Window-Specific Overrides" tab
4) add some rules
5) click "Apply"
6) click "OK"
7) repeat steps 2) and 3)

Actual Results:  
No overrides exist anymore

Expected Results:  
You should see your saved overrides

Qt: 5.5.1
KDE Frameworks: 5.17.0
4.1.15-gentoo
Comment 1 Hugo Pereira Da Costa 2015-12-27 10:41:54 UTC 
Can reproduce.
Something wrong with kconfig ... 
- note that if you press "ok" and only "ok" untill you quit the configuration, it will work
you can then reoppen add a new rule and ok->ok->ok will keep both
Problem occurs as soon as you click apply+ok, or multiple apply+change+apply.
Comment 2 Hugo Pereira Da Costa 2015-12-27 10:42:07 UTC 
Thanks for reporting !
Comment 3 Hugo Pereira Da Costa 2015-12-28 12:28:28 UTC 
Git commit af5f5feeb61f72acee206835d39f6bf7c5fe9475 by Hugo Pereira Da Costa.
Committed on 28/12/2015 at 12:19.
Pushed by hpereiradacosta into branch 'master'.

For standard configuration, rely on KCoreConfigSkeleton::load and ::save
For exceptions, explicitly write the relevant entries only.

M  +0    -3    kdecoration/config/oxygenconfigwidget.cpp
M  +12   -3    kdecoration/oxygenexceptionlist.cpp
M  +6    -6    kdecoration/oxygenexceptionlist.h

http://commits.kde.org/oxygen/af5f5feeb61f72acee206835d39f6bf7c5fe9475
Comment 4 Hugo Pereira Da Costa 2015-12-28 12:29:02 UTC 
Git commit 7c8c117cea387d3e3047702ae410055faabceeb9 by Hugo Pereira Da Costa.
Committed on 28/12/2015 at 11:21.
Pushed by hpereiradacosta into branch 'master'.

For standard configuration, rely on KCoreConfigSkeleton::load and ::save
For exceptions, explicitly write the relevant entries only.

M  +11   -3    kdecoration/breezeexceptionlist.cpp
M  +6    -6    kdecoration/breezeexceptionlist.h
M  +1    -4    kdecoration/config/breezeconfigwidget.cpp

http://commits.kde.org/breeze/7c8c117cea387d3e3047702ae410055faabceeb9
Comment 5 Hugo Pereira Da Costa 2015-12-28 12:29:58 UTC 
Git commit 7395b3ac024d8390af69acea94c673388a9e729a by Hugo Pereira Da Costa.
Committed on 28/12/2015 at 12:29.
Pushed by hpereiradacosta into branch 'Plasma/5.5'.

For standard configuration, rely on KCoreConfigSkeleton::load and ::save
For exceptions, explicitly write the relevant entries only.

M  +11   -3    kdecoration/breezeexceptionlist.cpp
M  +6    -6    kdecoration/breezeexceptionlist.h
M  +1    -4    kdecoration/config/breezeconfigwidget.cpp

http://commits.kde.org/breeze/7395b3ac024d8390af69acea94c673388a9e729a
Comment 6 Hugo Pereira Da Costa 2015-12-28 12:30:46 UTC 
Git commit 1dcaee368040692bf6de840465d40fe00a76f899 by Hugo Pereira Da Costa.
Committed on 28/12/2015 at 12:30.
Pushed by hpereiradacosta into branch 'Plasma/5.5'.

For standard configuration, rely on KCoreConfigSkeleton::load and ::save
For exceptions, explicitly write the relevant entries only.

M  +0    -3    kdecoration/config/oxygenconfigwidget.cpp
M  +12   -3    kdecoration/oxygenexceptionlist.cpp
M  +6    -6    kdecoration/oxygenexceptionlist.h

http://commits.kde.org/oxygen/1dcaee368040692bf6de840465d40fe00a76f899
Comment 7 Hugo Pereira Da Costa 2015-12-28 12:34:58 UTC 
Should fixed it (in breeze, and oxygen, in master and in 5.5 branch)
Feel free to double check, and reopen if not
(it does fix it here :))

best,

Hugo