Bug 357054

Summary:	Undoing quick razor clip cut actions freezes Kdenlive
Product:	[Applications] kdenlive	Reporter:	qubodup
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	crash
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	15.12.1
Sentry Crash Report:

Description qubodup 2015-12-22 16:21:53 UTC

kdenlive-git 15.12.0.r6719.1443863-1
mlt-git r4152.v0.9.2.374.g6b518f5-1

Steps to reproduce:
1. Start kdenlive
2. Import video
3. Add video to track
4. Quickly cut the video (or possibly slowly, while the system is under stress on possibly in a big project at high resolution/fps)
5. Undo the cuts

Expected results:
1. Some cut clicks are ignored or all undo commands are accepted

Actual result:
1. After a few undos, Kdenlive freezes.

Note: VLC was playing music at the same time

Video:
https://youtu.be/Jg5uqYC4wZY

Here's the output from such an experiment
http://curlpaste.com/id/bcl2in

Comment 1 Jean-Baptiste Mardelle 2015-12-22 22:06:00 UTC

Git commit 4d4e7fd96375dd7a986968ba048ffd1e159f04ab by Jean-Baptiste Mardelle.
Committed on 22/12/2015 at 22:05.
Pushed by mardelle into branch 'Applications/15.12'.

Fix corruption and freeze on razor undo

M  +2    -2    src/timeline/customtrackview.cpp
M  +1    -1    src/timeline/timeline.cpp
M  +2    -0    src/timeline/track.cpp

http://commits.kde.org/kdenlive/4d4e7fd96375dd7a986968ba048ffd1e159f04ab

Comment 2 qubodup 2015-12-22 22:40:47 UTC

kdenlive-git v15.12.0-32-g4d4e7fd Applications/15.12

Excellent, I can't seem to be able to trigger a freeze any more.

However
1. When using undo, some of the undo actions cause the warning/error sound and message "Cannot find clip to cut" - perhaps unsuccessful cuts are being recorded to the history?
2. If I hold-press Ctrl+Z, Kdenlive crashes.

Video:
https://youtu.be/Ndv3vPrkMPY

Comment 3 Jean-Baptiste Mardelle 2015-12-23 21:24:12 UTC

I just fixed the unsuccessful cuts recorded in undo history problem in 15.12 branch, but cannot reproduce the crash. Can you update to latest git, try to see if still present and get a backtrace if it crashes ?

Comment 4 qubodup 2015-12-25 10:38:25 UTC

Fortunately, I can't reproduce any of the issues any more. Thanks!