| Summary: | Crash in KRunner with un-threadsafe KIconLoader | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | derwesermann |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | bhush94, gaddman, jcraqueador, mklapetek, plasma-bugs, rcoe, stratiladimitrie, wbauer1 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.4.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
derwesermann
2015-12-20 14:41:26 UTC
Thread 2.
>#6 QHashData::rehash (this=0x1acf5f0, hint=9) at tools/qhash.cpp:602 #7 0x00007fb86ecbddbc in KIconLoader::hasIcon(QString const&) const () from /usr/lib64/libKF5IconThemes.so.5
Thanks.
I imagine this is KIconLoader not being thread safe.
*** Bug 360103 has been marked as a duplicate of this bug. *** Should be moved to frameworks-iconthemes then? Maybe. Though then it would just get ignored there and it only affects plasma/krunner so it's us who have to fix it. It would also be fixed by https://codereview.qt-project.org/#/c/140446/ which is blocked because although it fixes a problem we do encounter, it doesn't also fix some hypothetical problem that we don't have \o/ krunner did not crash -- two threads are stuck in an endless cycle two threads are attempting to reshash the same KIconLoader object mAvailableIcons Qt v5.6.1 plasma5-workspace-5.7.3 17 Thread 0x7fa67f7fe700 (LWP 7391) "GlobalQueue[05]" 0x00007fa6dab99c33 in QHashData::rehash (this=0x2670c70, hint=<optimized out>) at tools/qhash.cpp:642 * 24 Thread 0x7fa67ffff700 (LWP 7398) "GlobalQueue[12]" 0x00007fa6dab99c3b in QHashData::rehash (this=0x2670c70, hint=<optimized out>) at tools/qhash.cpp:642 p this $3 = (QHashData * const) 0x2670c70 [Switching to thread 17 (Thread 0x7fa67f7fe700 (LWP 7391))] p this $4 = (QHashData * const) 0x2670c70 Seems to be the same as bug#355122. Should be fixed in Plasma 5.8 (and Frameworks 5.24), by the following commits: https://quickgit.kde.org/?p=krunner.git&a=commit&h=0314c4d16ecff82f75a97d0bf8c0ef5ed29673f3 https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=e1692f1a21458986fac18daf6eb1d1037c9d5051 https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=f7c41dba58ab7a50c3ff38a9f7701ab2c03b81b2 And these two are necessary in addition, to still have icons displayed in the search results: https://quickgit.kde.org/?p=milou.git&a=commit&h=5e0d799f63796741efff3ff3d780df81f03dd66f https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=6fd35500d5cc46301f49d3fa452a51cb2c78cdae It's not quite the same, but it is still fixed by those commits (In reply to David Edmundson from comment #7) > It's not quite the same, but it is still fixed by those commits I meant that it seems to be the same underlying issue... ;-) *** Bug 368788 has been marked as a duplicate of this bug. *** *** Bug 372031 has been marked as a duplicate of this bug. *** |