Bug 356790

Summary: Containment-controls theme elements in panel resizing mode are mixed up
Product: [Plasma] plasmashell Reporter: obnosim
Component: PanelAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: bhush94, kde, plasma-bugs
Priority: NOR    
Version: 5.5.0   
Target Milestone: 1.0   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Color-coded containment-controls.svg
Color-coded file

Description obnosim 2015-12-16 19:48:44 UTC
Created attachment 96134 [details]
Color-coded containment-controls.svg

The attachment is a series of screenshots of a panel set on the right side of my monitor, with the resizing toolbars activated. You can see in the first part of it (using a theme in which the elements were replaced by solid colors for the sake of the report) that the same containment-control element (the green one) is used to control both the upper maximum and the lower minimum positions, and another one (the blue one) is used for both the upper minimum and the lower maximum. Plasma properly mirrors the elements as needed, however it mixes them up. The green element should always be on the right in this case, and the blue one should always be on the left. I believe this went unnoticed because both elements are identical in Breeze.
See the second part of the attachment for an example of how this breaks themes that use non symmetrical elements. The exact same widgets/containment-controls.svg file worked correctly under Plasma 4.
Comment 1 David Edmundson 2015-12-20 21:36:26 UTC
Can you attach your SVGs you used to make this then please.
Comment 2 obnosim 2015-12-21 18:02:22 UTC
Created attachment 96237 [details]
Color-coded file

I did not keep the original color-coded SVG, so here is a recreation of it. I added visible labels on the elements so you can easily tell they're mixed up (e.g. max elements have "max" written on them and min elements have "min").
Comment 3 David Edmundson 2015-12-21 18:03:04 UTC
Thanks
Comment 4 David Edmundson 2015-12-25 18:15:04 UTC
Git commit 426a24c051d187875abc0e373cdc252f151b1d21 by David Edmundson.
Committed on 25/12/2015 at 18:14.
Pushed by davidedmundson into branch 'Plasma/5.5'.

Use the right graphics for min and max sliders

We never noticed on Breeze because they look the same.
REVIEW: 126498

M  +2    -2    desktoppackage/contents/configuration/panelconfiguration/Ruler.qml

http://commits.kde.org/plasma-desktop/426a24c051d187875abc0e373cdc252f151b1d21