Bug 356781

Summary:	Yakuake tab bar looks bad on High DPI monitors
Product:	[Applications] yakuake	Reporter:	Alex Richardson <arichardson.kde>
Component:	general	Assignee:	Eike Hein <hein>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	4k1r4.rulez, claudius.ellsel, mail2abhisek.maiti, signupemail, spiderx
Priority:	NOR
Version First Reported In:	Git (Frameworks 5)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	screenshot of the tab bar

Description Alex Richardson 2015-12-16 15:19:08 UTC

I recently got a HighDPI monitor and noticed that the tab bar of Yakuake is too small.
Looking at the code it appears that it is using hard-coded pixel sizes for the themes.
Ideally it should be based on the size of the fonts and possibly use SVG for theming.

Reproducible: Always

Comment 1 Alex Richardson 2015-12-16 15:20:07 UTC

Created attachment 96130 [details]
screenshot of the tab bar

Comment 2 Eike Hein 2015-12-16 15:25:33 UTC

I recently got a hidpi monitor as well and feel the pain. Unfortunately this won't really be solved any time soon, but I do have concrete plans for a rewrite of the UI to address it.

Comment 3 Alex Richardson 2015-12-16 15:29:24 UTC

Good to hear that you already have plans. If you have any code that needs testing, I'd be happy to do it. It probably makes sense to test it on multiple monitors with different DPI (mine is 157 DPI).

Comment 4 Eike Hein 2015-12-16 15:37:45 UTC

I'll make Yakuake follow the Plasma device pixel ratio calculation since it's sort of like a shell element.

Here's the plan, roughly:

- Slap the Konsole KPart stack in front of a Qt Quick scene rendering the rest
- Expose all the UI info in the scene as models and props
- Use KPackage to enumerate and load new QML-based themes
- Install a Qt Quick plugin registering a bunch of QQuickItems that can load and render legacy Yakuake skin elements
- Install a theme KPackage that implements the classic UI using those QQuickItems
- The skin list in the config dialog displays a merged list of old skins and new skins, if a skin is determined to be in the old format it'll internally go through the legacy compatibility theme which then loads those theme elements keyed by skin name
- Make a theme KPackage that implements the UI using Qt Quick Controls 2 and styles them with SVG elements
- Scale new-style themes like this by Plasma device pixel ratio

Comment 5 signupemail 2018-12-16 23:42:26 UTC

Some three years later, and I too have the same problem.

Comment 6 4k1r4.rulez 2018-12-19 11:37:16 UTC

Per my testing it seems that the problem exists only in cases where instead of scaling user set font DPI to non default values OR used both scaling and custom DPI.

Comment 7 Abhisek Maiti 2020-01-17 08:49:07 UTC

Why this bug still exists after being reported 5 years ago?

Comment 8 Claudius Ellsel 2020-09-01 21:00:24 UTC

(In reply to Abhisek Maiti from comment #7)
> Why this bug still exists after being reported 5 years ago?

Apparently nobody had the time to implement the required changes.

Comment 9 Claudius Ellsel 2020-09-01 21:43:49 UTC

Seems to be a duplicate. Marking accordingly. The other one is older and seems to be a bit broader, although this one contains more useful details.

*** This bug has been marked as a duplicate of bug 342804 ***