Bug 356672

Summary:	digikam 4.14.0 failed to build against lensfun 0.3.2
Product:	[Applications] digikam	Reporter:	Willy Sudiarto Raharjo <willysr>
Component:	Portability-Compilation	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, rdieter
Priority:	NOR
Version:	4.14.0
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/0f159981176faa6da701f112bfe557b79804d468	Version Fixed In:	5.0.0
Sentry Crash Report:

Description Willy Sudiarto Raharjo 2015-12-14 11:54:35 UTC

I'm trying to rebuild digikam 4.14.0 against lensfun 0.3.2 and failed with an error message

In file included from
/tmp/SBo/digikam-4.14.0/core/libs/dimg/filters/lens/lensfuniface.h:29:0,
                 from
/tmp/SBo/digikam-4.14.0/core/libs/dimg/filters/lens/lensfunfilter.cpp:35:
/usr/include/lensfun/lensfun.h:2506:5: error: template with C linkage
     template<typename T> static void ModifyColor_Vignetting_PA (
     ^
/usr/include/lensfun/lensfun.h:2508:5: error: template with C linkage
     template<typename T> static void ModifyColor_DeVignetting_PA (
     ^
core/app/CMakeFiles/digikamcore.dir/build.make:2693: recipe for target
'core/app/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/lens/lensfunfilter.cpp.o'
failed
make[2]: *** [core/app/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/lens/lensfunfilter.cpp.o]
Error 1
make[2]: Leaving directory '/tmp/SBo/digikam-4.14.0/build'
CMakeFiles/Makefile2:7965: recipe for target
'core/app/CMakeFiles/digikamcore.dir/all' failed
make[1]: *** [core/app/CMakeFiles/digikamcore.dir/all] Error 2
make[1]: Leaving directory '/tmp/SBo/digikam-4.14.0/build'
Makefile:141: recipe for target 'all' failed
make: *** [all] Error 2

i think it's mentioned on the lensfun's changelog

=======================================
  0.3.1 --> 0.3.2  (2015-11-16)
=======================================

* Incremented binary version number
* Improved vignetting interpolation

I haven't tested on 5.0 Beta 2, but i guess it's also failing there

Reproducible: Always

Steps to Reproduce:
1. upgrade to lensfun 0.3.2
2. rebuild digiKam 4.14.0
3.

Actual Results:  
In file included from
/tmp/SBo/digikam-4.14.0/core/libs/dimg/filters/lens/lensfuniface.h:29:0,
                 from
/tmp/SBo/digikam-4.14.0/core/libs/dimg/filters/lens/lensfunfilter.cpp:35:
/usr/include/lensfun/lensfun.h:2506:5: error: template with C linkage
     template<typename T> static void ModifyColor_Vignetting_PA (
     ^
/usr/include/lensfun/lensfun.h:2508:5: error: template with C linkage
     template<typename T> static void ModifyColor_DeVignetting_PA (
     ^
core/app/CMakeFiles/digikamcore.dir/build.make:2693: recipe for target
'core/app/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/lens/lensfunfilter.cpp.o'
failed
make[2]: *** [core/app/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/lens/lensfunfilter.cpp.o]
Error 1
make[2]: Leaving directory '/tmp/SBo/digikam-4.14.0/build'
CMakeFiles/Makefile2:7965: recipe for target
'core/app/CMakeFiles/digikamcore.dir/all' failed
make[1]: *** [core/app/CMakeFiles/digikamcore.dir/all] Error 2
make[1]: Leaving directory '/tmp/SBo/digikam-4.14.0/build'
Makefile:141: recipe for target 'all' failed
make: *** [all] Error 2

Expected Results:  
digikam is built

Tested on Slackware current
KDE 4.14.x
GCC 5.2.0
GLIBC-2.22.0
lensfun-0.3.2
opencv-3.0.0

Comment 1 caulier.gilles 2015-12-14 21:42:52 UTC

Git commit 0f159981176faa6da701f112bfe557b79804d468 by Gilles Caulier.
Committed on 14/12/2015 at 21:41.
Pushed by cgilles into branch 'master'.

fix compilation with Lensfun 0.3.2
It still compatible with older lensfun releases.
FIXED-IN: 5.0.0

M  +0    -3    libs/dimg/filters/lens/lensfuniface.h

http://commits.kde.org/digikam/0f159981176faa6da701f112bfe557b79804d468