Bug 356495

Summary:	15.11.90+48 - When "Split" button is clicked on a clip with no effects, clip monitor still enters "split mode". Should remain in standard mode.
Product:	[Applications] kdenlive	Reporter:	Unknown <null>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	15.12.1
Sentry Crash Report:

Description Unknown 2015-12-11 00:00:20 UTC

I really like the new compare effect feature! One issue that came up, however, was when I click on the "Split" button on a clip that had no effects added, the prompt came up "This clip has no effects", which is all well and good... but the monitor went into a different "compare" mode regardless. Which surprised me.

Consider:
1. If there are no effects on a clip, grey out the "split" button?
2. If there are no effects on a clip and the split button is pressed, don't have the monitor enter the split or compare mode?

For that matter... would the tooltip be more appropriately titled "Compare" instead of Split? More a thought than a suggestion. :)

Reproducible: Always




Tested on Kdenlive 15.11.90+48 via vpinon's Wily ppa. Using Ubuntu GNOME 15.10 x64 w/ Gnome 3.16.

Comment 1 Jean-Baptiste Mardelle 2015-12-14 22:28:12 UTC

Thanks for the comments, implemented in master and in 15.12 branch (for 15.12.1)
I didn't change the tooltip yet, not sure what is best combination of words... Currently we have Split / Unsplit (tooltip changes depending on action's state). 

Any idea ? Compare / Original ?

Comment 2 Unknown 2015-12-15 04:40:33 UTC

Awesome!

What about "Preview Effects" for both tooltips, then change the icon itself somehow to show when the split compare feature is enabled and disabled, instead of relying on the tooltip text? Like when the edit mode button is enabled or disabled on the Project Monitor: the background is grey when it's enabled, and the default UI color when it isn't. I think once the compare mode is enabled in the clip monitor, the user will get that there's a split between the two that allows them to compare one side with effects and another without.

Comment 3 Unknown 2015-12-15 05:22:24 UTC

I just realized that the icon does change when it's clicked. I get the direction you're going with it... but maybe consider if the button should behave more like the edit mode in Project monitor? Would seem more congruent in each monitor's behavior, yeah?

Comment 4 Jean-Baptiste Mardelle 2015-12-16 17:37:14 UTC

Git commit 409a0b1bb0eb68e10b545342d4296cea0d2f4a2a by Jean-Baptiste Mardelle.
Committed on 16/12/2015 at 17:37.
Pushed by mardelle into branch 'Applications/15.12'.

Make split effect button checkable to that is is easier to see if enabled

M  +15   -12   src/monitor/monitor.cpp

http://commits.kde.org/kdenlive/409a0b1bb0eb68e10b545342d4296cea0d2f4a2a

Comment 5 Jean-Baptiste Mardelle 2015-12-16 19:02:38 UTC

Git commit e13c85f0dffcaeda3d154994605a33aa1e5737df by Jean-Baptiste Mardelle.
Committed on 16/12/2015 at 19:00.
Pushed by mardelle into branch 'master'.

Make split effect button checkable to that is is easier to see if enabled

M  +15   -12   src/monitor/monitor.cpp

http://commits.kde.org/kdenlive/e13c85f0dffcaeda3d154994605a33aa1e5737df