Bug 356369

Summary:	Choose brush preset - update
Product:	[Applications] krita	Reporter:	eliotJ <osxyz>
Component:	Usability	Assignee:	Halla Rempt <halla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	animtim, halla
Priority:	NOR
Version First Reported In:	2.9.9
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	First Second brush chooser in master

Description eliotJ 2015-12-07 17:57:36 UTC

I’m using Krita for many months now. Lately I tried to edit name of some tag for brush presets... And I can’t found how do this... I asked on IRC, if this is even possible...
After all I noticed that I was mainly confused by green “+” icon from “Choose brush preset” popup window. I simply haven’t expected that this green “+” do anything more than add tag... This is why I even haven’t clicked it at first.

My proposal for updating icons and also for better identify element of tags system in “Choose brush preset” popup window.

Reproducible: Always

Comment 1 eliotJ 2015-12-07 18:01:01 UTC

Created attachment 95926 [details]
First

Comment 2 eliotJ 2015-12-07 18:04:40 UTC

Created attachment 95927 [details]
Second

Comment 3 Halla Rempt 2015-12-10 07:55:16 UTC

Created attachment 95965 [details]
brush chooser in master

Hi Eliot,

If I'm looking at krita 3.0 pre-alpha, those icons are updated and look like what you proposed in the second attachment. I'm aware I've been dropping the ball when it comes to bug reports. What's missing is the delete icon, it seems. Could you coordinate with Animtim on irc about this issue? He's doing the new icon set.

Comment 4 animtim 2015-12-10 10:15:44 UTC

Hi,
yes I added the corresponding icons to the sources when I did the icon update, but never found how to override the oxygen loaded icons.
Note, it's the same on gradient and pattern selectors.

Boudewijn will look at it soon.

Comment 5 eliotJ 2015-12-13 22:13:15 UTC

Nice to see some progress of these things was already done...

After disscusing on IRC with Boud I write here:
I want point two things:
1. Save icon (these near tags text field - right down corner of the brush selector window) is missed in these Krita 3.0 pre-alpha screenshot.

2. I have big hopes for these "Tag" text intead of "+" icon. Boud thinking about some kind of icon describing better functionality of this button than "+". IMHO it can be tricky to designing good icon... Text "Tag" can be also temporairy solution (easy and fast to add until good icon would be designed).

Comment 6 Halla Rempt 2016-03-18 08:26:41 UTC

We've got all new icons now, but we'll stay with a + icon for adding tags. Trying to make  a different tag icon would make for a really fiddly image, so this is something people just will have to learn.