Bug 355936

Summary:	15.12.0: Spacer tool moves transitions of locked tracks
Product:	[Applications] kdenlive	Reporter:	Wegwerf <wegwerf-1-2-3>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	snd.noise, wegwerf-1-2-3
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kdenlive/816bccad51fbfa139c8054a1c8b86661e3e97c1d	Version Fixed In:	15.12.1
Sentry Crash Report:
Attachments:	locked track transition selection bug testcase

Description Wegwerf 2015-11-26 11:55:23 UTC

When using the spacer tool to move clips and transitions from a certain timepoint on, it correctly does not move clips on locked tracks. However, transitions on those locked tracks will be moved. This usually is not the intended behavior because transitions closely correspond with the locked clips.

Reproducible: Always

Steps to Reproduce:
1. Create a color clip and place it one the topmost track. Make it 5s long.
2. Add a transition to this clip which spans the whole clip on the track.
3. Lock topmost track
4. Add the color clip to the next track, let it overlap the first clip on the topmost track in the timeline, with an offset, say 1s.
5. Select spacer tool.
6. Move second color clip in timeline.

Actual Results:  
Transition on locked topmost track moves together with clips on unlocked tracks.

Expected Results:  
Transitions on locked tracks do not move.

Comment 1 farid 2015-12-13 22:34:04 UTC

i cant reproduce using 15.12 compiled today from git.

Comment 2 Wegwerf 2015-12-19 19:48:46 UTC

I still *do* reproduce using 15.12.0 from git Applications/15.12.

Comment 3 Wegwerf 2015-12-19 19:50:52 UTC

More details:
1. I can reproduce using an existing 15.11.90 project loaded into 15.12.0.
2. I cannot reproduce on a new 15.12.0 project.

Comment 4 Wegwerf 2015-12-19 20:00:02 UTC

More details:
1. Add an existing 15.11.90 project as a clip to a new 15.12.0 project.
2. Drag clip into timeline.
3. Timeline > Current Clip > Expand Clip
4. Lock first track with clip & transition.
Now, "move" mode correctly doesn't touch the transition on the first clip anymore. But when using the project directly, problem persists.

Comment 5 Wegwerf 2015-12-19 20:08:59 UTC

Finally found out while working on a minimized test case that unlocking and locking the track causes some MLT/project state cleanup in that then locking works as expected, so that "move" mode doesn't move the locked transition anymore.

Comment 6 Wegwerf 2015-12-19 20:21:59 UTC

Created attachment 96202 [details]
locked track transition selection bug testcase

1. Load test case project into Kdenlive 15.12.0; tell Kdenlive to replace missing clip with placeholder.
2. Do *not* unlock topmost track. Enter move mode by keying "m". Then select clip on track 2. Note how the transition on locked track 1 gets selected too.
3. Unlock track 1, immediately lock it again.
4. Select clip on track 2 again, notice that locked transition doesn't get selected anymore.

Comment 7 Wegwerf 2015-12-19 20:22:31 UTC

Created and attached testcase project showing the bug being present still on 15.12.0.

1. Load test case project into Kdenlive 15.12.0; tell Kdenlive to replace missing clip with placeholder.
2. Do *not* unlock topmost track. Enter move mode by keying "m". Then select clip on track 2. Note how the transition on locked track 1 gets selected too.
3. Unlock track 1, immediately lock it again.
4. Select clip on track 2 again, notice that locked transition doesn't get selected anymore.

Comment 8 Wegwerf 2015-12-21 16:34:29 UTC

I've now noticed that such upgraded projects still keep this bug alive, albeit during a Kdenlive session the bug goes away after unlocking and relocking the offending track. The bug persists saving and reloading such projects and reappears on reload. Again, during the editing session you can mask the bug by unlocking and relocking the track. Save, reload, reappears.

Comment 9 Jean-Baptiste Mardelle 2015-12-21 21:16:43 UTC

Git commit 00d61732bb0088603729073ae22b6cc7a2655348 by Jean-Baptiste Mardelle.
Committed on 21/12/2015 at 21:16.
Pushed by mardelle into branch 'master'.

Fix locked track locking wrong transitions on project loading

M  +1    -1    src/timeline/timeline.cpp

http://commits.kde.org/kdenlive/00d61732bb0088603729073ae22b6cc7a2655348

Comment 10 Jean-Baptiste Mardelle 2015-12-22 15:04:06 UTC

Git commit 816bccad51fbfa139c8054a1c8b86661e3e97c1d by Jean-Baptiste Mardelle.
Committed on 22/12/2015 at 15:03.
Pushed by mardelle into branch 'Applications/15.12'.

Fix locked track locking wrong transitions on project loading

M  +2    -2    src/timeline/timeline.cpp

http://commits.kde.org/kdenlive/816bccad51fbfa139c8054a1c8b86661e3e97c1d

Comment 11 Wegwerf 2015-12-22 19:47:14 UTC

Works. Thank you very much!