| Summary: | RPMlint complies of unversioned library | ||
|---|---|---|---|
| Product: | [Applications] partitionmanager | Reporter: | Mattia <mattia.verga> |
| Component: | general | Assignee: | Andrius Štikonas <andrius> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kpmcore/4da5a0e8a2bca603428914416fe9888b9dc6eb34 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | signature.asc | ||
|
Description
Mattia
2015-11-25 16:39:32 UTC
I forgot to say this is needed to fix for packaging KPMcore in Fedora. Git commit 4da5a0e8a2bca603428914416fe9888b9dc6eb34 by Andrius Štikonas. Committed on 25/11/2015 at 16:49. Pushed by stikonas into branch 'master'. Make sure so version is set on the target. M +6 -1 CMakeLists.txt http://commits.kde.org/kpmcore/4da5a0e8a2bca603428914416fe9888b9dc6eb34 Thanks for reporting it. I had something setting soversion in CMakeLists.txt but it was incomplete. Hopefully it works not, if not please reopen. It works fine and kpmcore is now ok. But there's also kpmgui.so in partitionmanager that should be versioned. Thanks. (In reply to Mattia from comment #4) > It works fine and kpmcore is now ok. > > But there's also kpmgui.so in partitionmanager that should be versioned. > > Thanks. kpmgui.so is a private library (basically it is the whole partitionmanager). Should I just move it to /usr/lib/partitionmanager ? (In reply to Andrius Štikonas from comment #5) > kpmgui.so is a private library (basically it is the whole partitionmanager). > Should I just move it to /usr/lib/partitionmanager ? In the link I provided in Comment #1 it says: The standard way to move a private library is to create a new directory under %{_libdir} e. g., /usr/lib/myapp. Don't list it in /etc/ld.so.conf files! Instead, use a rpath to let the application locate the library. So, yes, I think moving under /usr/lib/partitionmanager (or /usr/lib64/partitionmanager) should be the best thing. I was wrong. Conventions for libraries requires always fully versioned names and proper soname: http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html Only moving kpmgui.so under a private directory is not enough. Created attachment 96038 [details]
signature.asc
Oh, I see. Maybe I should just get rid of that library, since there is almost
nothing outside it in partitionmanager executable. I think only main.cpp file.
I've removed kpmgui library, so unversioned library issue should be resolved. |