Bug 355864

Summary:	Icon of the battery seems always more empty that it is
Product:	[Plasma] plasmashell	Reporter:	Olivier Churlaud <olivier>
Component:	Theme - Breeze	Assignee:	visual-design
Status:	RESOLVED FIXED
Severity:	normal	CC:	f1u77y, kainz.a, mklapetek, notmart, plasma-bugs
Priority:	NOR	Flags:	olivier: VisualDesign+
Version:	5.4.3
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Battery icon at 57%

Description Olivier Churlaud 2015-11-24 21:38:45 UTC

When the battery is around 50% it looks like more than half empty. It's already red at 20%.

You should be more optimistic :) Now a battery at 20% lasts more than 2 hours!

More seriously, I think the icons should look a little more full.

Reproducible: Always

Comment 1 Olivier Churlaud 2015-11-24 21:44:59 UTC

Created attachment 95713 [details]
Battery icon at 57%

On the attachement you can see how it looks at 57%. It's more than half but it looks like I should run to plug the alimentation in.

Comment 2 Kai Uwe Broulik 2015-11-24 21:51:16 UTC

Re-assigning to Breeze theme. I agree that the icon is difficult to see.

The 22-22-Fill50 element used in your machine indeed looks more like 30%. Also, Fill30 is red already which means the battery icon turns red at 35% which easily translates to more than two hours of battery life on a modern laptop. The 22-22 and regular size graphics are also inconsistent in when their fill and when they will turn red.

Comment 3 Martin Klapetek 2015-11-25 02:06:44 UTC

Can we use the same coloring magic on the low-battery-state that we use in breeze-dark icons? Ie. take the normal black icons and color them white.

Cause I have low battery set to 10% so ideally I'd like to see the battery red only when it gets below 10%.

Comment 4 Marco Martin 2015-11-25 11:46:17 UTC

so, 30% and 20% still black? (or white)

Comment 5 Marco Martin 2015-11-25 11:50:16 UTC

Git commit df88cef4a8ef5dd4ee7e7ea5a88406c36ec40753 by Marco Martin.
Committed on 25/11/2015 at 11:49.
Pushed by mart into branch 'master'.

red at 10%

Change-Id: I60696f81cbda85018a580fd5b077ff1c2bc90d6d

M  +-    --    src/desktoptheme/breeze/icons/battery.svgz

http://commits.kde.org/plasma-framework/df88cef4a8ef5dd4ee7e7ea5a88406c36ec40753

Comment 6 Martin Klapetek 2015-11-25 13:27:02 UTC

Well that's not exactly what I meant. I have powerdevil set to "low battery" at 5%, so being red at 20% makes no sense for me cause even at 10% I still have something about an hour of time left.

So what I was proposing, rather, is following the powerdevil setting for "low battery" level for coloring the battery red. If that is possible.

Comment 7 Martin Klapetek 2015-12-04 21:19:29 UTC

*** Bug 356295 has been marked as a duplicate of this bug. ***

Comment 8 andreas 2015-12-06 11:49:18 UTC

should work now. please check (https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=42952018ad26aa5b66cda74e7a2ea69a80187ffa)

the battery stat is now easier to recognize and the icon is 2px larger that it fits better to the other vertical status bar icons.

Comment 9 Martin Klapetek 2015-12-15 22:40:23 UTC

*** Bug 356746 has been marked as a duplicate of this bug. ***

Comment 10 Olivier Churlaud 2016-02-03 15:32:54 UTC

Can be closed? I would say yes...

Comment 11 andreas 2016-02-03 15:56:21 UTC

The icons were updated and the stylesheet stuff work.

thanks for reporting the bug and help KDE/Plasma to make it even better

Andreas Kainz