Bug 355835

Summary:	Location bar trims trailing whitespace
Product:	[Applications] dolphin	Reporter:	Thomas <tux12345>
Component:	bars: location	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	frank78ac, russellgreene8
Priority:	NOR
Version First Reported In:	15.08.2
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	A screenshot compilation showing the described behaviour.

Description Thomas 2015-11-24 12:20:15 UTC

Bug triggers when you want to use the location bar to navigate into a folder that’s name contains trailing whitespace.
Suppose there is a folder '~/whitespace /foobar'.
Navigation into folder foobar is possible. When clicking on 'whitespace ' in the location bar Dolphin gives 2 errors:
1. the GUI displays an error: The file or folder /home/<username>/whitespace does not exist.
2. the console (F4) gives 'bash: cd: /home/<username>/whitespace: No such file or directory'
Note that the trailing whitespace in the folder name is trimmed away.

Reproducible: Always

Steps to Reproduce:
1. Create a folder with trailing whitespace in the name: e.g. 'whitespace ' (without quotes ofc.)
2. Optional: create a subfolder of any name inside
3. navigate into the folder 'whitespace  ' or the subfolder.
4. use the location bar to go into the folder 'whitespace  '.

Actual Results:  
Dolphin shows the error that folder 'whitespace' (note the trimmed whitespace) does not exist.

Expected Results:  
Dolphin should switch to the folder 'whitespace '

When opening the console (F4), the console output shows the same error.

Comment 1 Russell Greene 2015-12-27 02:37:10 UTC

Add the trailing / after whitespace .

ie. enter ~/whitespace / instead of ~/whitespace

This works for me.

Comment 2 Thomas 2015-12-28 10:23:48 UTC

Yes, the text input in the location bar works as expected.
The real problem is that the graphical path view (which is default) is broken.
In graphical mode, it does trim trailing whitespace away and then adds a trailing '/' when clicking on the folder 'whitespace '.
By the way: The 'Up'-Button does not show the wrong behaviour when it is added to the toolbar.
When you are in the folder '/home/<username>/whitespace /bar/' you can use 'Up' to go one level up without a problem.

You can work around this bug by modifying the settings:
- Check 'Editable location bar' in the settings
Then you cannot encounter this bug, but everyone using the default settings can encounter it.

Comment 3 Frank Reininghaus 2015-12-31 09:31:43 UTC

(In reply to Thomas from comment #2)
> The real problem is that the graphical path view (which is default) is
> broken.
> In graphical mode, it does trim trailing whitespace away and then adds a
> trailing '/' when clicking on the folder 'whitespace '.

Could you please describe in more detail how you can reproduce this problem? I tried a couple of ways to navigate to the folder "whitespace " in breadcrumb mode (the mode where there are clickable folder names shown between arrows, I guess that is what you mean with "graphical"?) in current master, but I never got any errors.

Thanks for your help!

Comment 4 Thomas 2016-01-02 21:58:38 UTC

Created attachment 96421 [details]
A screenshot compilation showing the described behaviour.

A screenshot compilation showing the described behaviour.
1. Screenshot: Location Bar in edit mode showing the current directory.
2. Screenshot: Location Bar in Breadcrumb mode, additionally opened the terminal.
3. Screenshot: Error shows up after clicking on the folder 'whitespace ' Note the error in the terminal as well
4. Screenshot: Navigating up using the 'Up'-Button works as intended. (note the console log)

Comment 5 Frank Reininghaus 2016-01-03 10:56:18 UTC

Thanks for the screenshot and the detailed instructions!

I can reproduce the problem with Dolphin 15.08.3, KDE Frameworks 5.16 and Qt 5.5.1 as provided by OpenSuse. With Dolphin+KDE Frameworks built from the master branch, it works fine though.

I did some more testing and digging in the git history of Dolphin and KIO and found that this issue is fixed by

https://quickgit.kde.org/?p=kio.git&a=commit&h=9dbe36f734b5b839b2a6a934fad29d639e954498

So this issue should be fixed once you upgrade to KIO 5.17 or later.