Bug 355825

Summary:	git master 2015-11-24 - Pan & Zoom effect uses proxy resolution for calculations
Product:	[Applications] kdenlive	Reporter:	Evert Vorster <evorster>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	15.12.1
Sentry Crash Report:

Description Evert Vorster 2015-11-24 09:04:41 UTC

I run my drone at 4k resolution, and obviously I'll need proxy clips to make the editing process a little smoother, especially since I have a longish filter stack to correct the GoPro protune footage. 

As I normally render out to 1080p, I am able to zoom in on the 4K footage to about 200% without losing picture quality. However, if I am using proxy clips, hitting the "Zoom to original size" button on the pan & zoom effect, it zooms to the size of the proxy clip. Which is plainly wrong. 

Also, my footage is in 16:9 aspect ratio, and there is no proxy pre-set for that, so I had to make a pre-set for it, or live with black bars and distorted footage when using proxy clips.

Reproducible: Always

Steps to Reproduce:
1. Load 4k footage
2. Enable proxy clip ( might have to make a pre-set for 16:9 aspect)
3. Load proxy clip on timeline
4. Add pan & zoom effect
5. Hit "Zoom to original size"

Actual Results:  
Pan & zoom zooms to size of proxy clip

Expected Results:  
Should zoom to size of footage

The workaround of course is to do some math and figure out for myself what the maximum zoom is for a certain footage, and just type that in manually.

Comment 1 Evert Vorster 2015-12-27 08:21:38 UTC

This one should be an easy fix, since the resolution of the original is available. 

Just use the original's metadata for the calculations on zoom size for zoom to 100%, please.

Comment 2 Jean-Baptiste Mardelle 2015-12-27 22:54:53 UTC

Git commit 5a6235b120993cc31908847c847bd01fdecd3818 by Jean-Baptiste Mardelle.
Committed on 27/12/2015 at 22:54.
Pushed by mardelle into branch 'Applications/15.12'.

Use original clip properties, not proxy for effects / display
Related: bug 356643

M  +1    -1    src/bin/abstractprojectitem.h
M  +1    -1    src/bin/bin.cpp
M  +2    -2    src/bin/projectclip.cpp
M  +1    -1    src/bin/projectclip.h
M  +1    -1    src/bin/projectfolder.cpp
M  +1    -1    src/bin/projectfolder.h
M  +1    -1    src/bin/projectfolderup.cpp
M  +1    -1    src/bin/projectfolderup.h
M  +1    -1    src/bin/projectsubclip.cpp
M  +1    -1    src/bin/projectsubclip.h
M  +2    -2    src/mltcontroller/bincontroller.cpp
M  +1    -1    src/mltcontroller/bincontroller.h
M  +24   -4    src/mltcontroller/clipcontroller.cpp
M  +2    -1    src/mltcontroller/clipcontroller.h
M  +11   -0    src/renderer.cpp

http://commits.kde.org/kdenlive/5a6235b120993cc31908847c847bd01fdecd3818

Comment 3 Evert Vorster 2015-12-29 02:34:32 UTC

Perfect fix.
Thanks