| Summary: | Icons should be pre-rendered to bitmaps at build-time | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Matthias Klumpp <matthias> |
| Component: | Icons | Assignee: | visual-bugs-null |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | hugo.pereira.da.costa, kainz.a, mklapetek |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Matthias Klumpp
2015-11-17 18:26:48 UTC
I'm not a big fan of using png files cause 1. we work on svg files so if we change something we have to sync the png files as well 2. git doens't work well with png files 3. the symbolic links have to work also for the png files (be aware of it) I would prefer something like a script when the icons were released the png files will be generated automatically. I like standards and if we don't use the standard folder structure I can change it. (In reply to andreas from comment #1) > I'm not a big fan of using png files cause > 1. we work on svg files so if we change something we have to sync the png > files as well > 2. git doens't work well with png files Yes, working with PNG as source material is not a good idea, that's why having an intermediate "make" step makes sense, which compiles the actual icon theme from the SVG source material. > 3. the symbolic links have to work also for the png files (be aware of it) That's an issue, but a solvable one. > I would prefer something like a script when the icons were released the png > files will be generated automatically. If you want to, I can come up with a script, or - since the breeze-icons repo already contains C++ code, with a small C++ helper application which does the conversion and symlinking in a user-friendly way. The advantage of using compiled code would be that it allows using QtSVG (which results in the same rendering as the current widgets get). > I like standards and if we don't use the standard folder structure I can > change it. It's not exactly a standard, but more a convention ;-) Building the folder structure at build-time would work too (and is probably necessary), so you could organize the files as you wish in the Git repo. Hi I remove a lot of unused svg text infos and now the icons have stylesheeds and are smale in size. so if you want to change the icons do it on runtime or when you install the icons. in the repository there will be only svg files. I hope this will work for you, cause I will work on svg files and png files are not needed for my work if it is better for the user, than convert the icons while install the svg files. > if it is better for the user, than convert the icons while install the svg files.
That's what Matthias asks for with this bug report...
Yes, storing bitmaps in Git would be insane... Still, the SVG images are a problem due to the issues outlines above, and compiling them to a reasonable amount of bitmaps at build-time should be easily possible. Unfortunately I have quite a lot of stuff to do at time, so creating a patch isn't at the top of my priority list - but it's on there :-) The stuff I wrote about changing the icon layout can be ignored btw, that was a quirk in the AppStream generator which has been resolved meanwhile, and there is really nothing to be gained by changing it. Although, if/when bitmaps are shipped, some layout changes would be useful... |