Bug 355380

Summary:	15.11.90: deleting topmost track with clip with transition does leave transition behind
Product:	[Applications] kdenlive	Reporter:	Wegwerf <wegwerf-1-2-3>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal	CC:	qubodup, wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	15.12.1
Sentry Crash Report:
Attachments:	Transition not deleted with track example

Description Wegwerf 2015-11-15 13:55:30 UTC

When deleting the topmost track that contains clips and transitions, the track itself gets removed. Yet the corresponding transitions at the topmost track survive and now slip down onto the new topmost track. However, this bug does not appear when the project is freshly created in 15.12.0, but when working with existing projects. Please see the example project attached.

Reproducible: Always

Steps to Reproduce:
1. Load attached Kdenlive project created with 15.08.3.
2. Delete topmost track.

Actual Results:  
Transition from topmost track reappears on now topmost track.

Expected Results:  
Transition on topmost track gets deleted together with topmost track.

This bug manifests itself in Kdenlive projects created in 15.08, but not (yet) created in 15.12.

Comment 1 Wegwerf 2015-11-15 13:56:36 UTC

Created attachment 95512 [details]
Transition not deleted with track example

This test case project was created in Kdenlive 15.08.3. It seems that only existing projects created before 15.12.0 trigger this bug.

Comment 2 Wegwerf 2015-11-15 14:13:48 UTC

The actual bug may be https://bugs.kde.org/show_bug.cgi?id=355381. This bug may just be another result of the same underlying track index handling bug.

Comment 3 qubodup 2015-12-22 19:06:23 UTC

Wow, what a testing session! I checked xml files top to bottom and ended up figuring out how the UI affects this behavior.

kdenlive-git 15.12.0.r6719.1443863-1
mlt-git r4152.v0.9.2.374.g6b518f5-1

Steps to reproduce (in a fresh project):
1. Start kdenlive (default tracks 3x v, 2x a)
2. Create color clip
3. Drag color clip to Video 1
4. Create affinite transition for the clip (v1-v2)
5. In properties of the transition, change "track" to "Video 3" (or any value other than "auto" and "Video 2")
6. Delete track Video 1

Expected result:
1. track, clip and transition get deleted

Actual result:
2. track and clip get deleted but the transition apparently "jumps down".

As a bonus, if you undo this, you end up with two transitions.

Video:
https://youtu.be/VSoio3qrDq4

Comment 4 Jean-Baptiste Mardelle 2015-12-22 21:02:00 UTC

Git commit d0a38e91fa43810b7c22082e022e9729e218fb72 by Jean-Baptiste Mardelle.
Committed on 22/12/2015 at 21:01.
Pushed by mardelle into branch 'Applications/15.12'.

Fix transitions left after track deletion

M  +3    -0    src/timeline/customtrackview.cpp
M  +17   -0    src/timeline/transitionhandler.cpp
M  +1    -0    src/timeline/transitionhandler.h

http://commits.kde.org/kdenlive/d0a38e91fa43810b7c22082e022e9729e218fb72

Comment 5 Wegwerf 2015-12-24 15:21:39 UTC

Works like a charm. Thank you very much! Happy Xmas!